Re: [PATCH 1/5] argv-array: Add argv_array_pop function [v2]

[Neil Horman <nhorman@tuxdriver.com>]

On Thu, Apr 05, 2012 at 10:20:58PM -0400, Jeff King wrote:
> On Thu, Apr 05, 2012 at 06:20:53PM -0700, Junio C Hamano wrote:
> 
> > >> > CC: Jeff King <peff@peff.net>
> > >> > CC: Phil Hord <phil.hord@gmail.com>
> > >> > CC: Junio C Hamano <gitster@pobox.com>
> > >> > ---
> > >> 
> > >> Please don't do "Cc:" here; they belong to your e-mail header.
> > >> 
> > > You mean place them below the snip line?  I can do that.
> > 
> > No.  When you review and fix typo in format-patch output, you can add
> > these to the e-mail header part and git-send-email will pick them up just
> > fine.
> 
> I think there is a legitimate conflict of interest here.
> 
> It's not clear exactly what "cc" tags in a commit message mean, because
> it is really a per-project thing. I don't work on the kernel, but I
> always took their cc tag to mean "these are people interested in this
> topic area". Send-email helpfully picks up that hint and cc's them on
> the emailed patch. And when the patch is applied, those cc lines remain,
> because people reading "git log" much later may find a bug in the patch,
> and it is helpful to tell them the people interested in the area.
> 
Thats more or less what its for.  Mostly CC's on a patch on lkml are meant to
direct peoples attention to patches for subsystems their interested in.  teh
kernels get_maintainers script generates these typically.  With the volume of
traffic on lkml its often easy for patches to get misplaced by individual
maintainers.  Recording that info in the commit message, while possibly useful,
is most often seen as a harmless side effect.

The major advantage of CC's in the commit log is that it lets you skip the
format-patch stage. I.E. you can just git-send-email directly and have all the
right people CC-ed. Thats very handy when you have a large changeset and the CC
list differs for individual patches.

Neil