From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755711Ab2DHOyk (ORCPT ); Sun, 8 Apr 2012 10:54:40 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:37058 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755579Ab2DHOyh (ORCPT ); Sun, 8 Apr 2012 10:54:37 -0400 Date: Sun, 8 Apr 2012 09:54:27 -0500 From: Serge Hallyn To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linux Containers , Cyrill Gorcunov , linux-security-module@vger.kernel.org, Al Viro , linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds Subject: Re: [REVIEW][PATCH 0/43] Completing the user namespace Message-ID: <20120408145427.GA20790@sergelap> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, Eric. While this approach has limitations and administrative overhead which I'd prefer it didn't, it also has huge benefits, especially faster id comparisons and, most importantly, type safety enforcing that the right kinds of uids are compared. So I endorse this approach. I've reviewed and acked many of the patches, some I still had questions on, but the approach as a whole gets an ack from me. thanks, -serge