From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755169Ab2DIHt5 (ORCPT ); Mon, 9 Apr 2012 03:49:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9665 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752935Ab2DIHtz (ORCPT ); Mon, 9 Apr 2012 03:49:55 -0400 Date: Mon, 9 Apr 2012 10:50:01 +0300 From: "Michael S. Tsirkin" To: Ren Mingxin Cc: Tejun Heo , James Bottomley , Jens Axboe , KVM , SCSI , LKML , VIRTUAL Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Message-ID: <20120409075001.GA27771@redhat.com> References: <4F7582B0.5010609@cn.fujitsu.com> <20120330152606.GB28934@google.com> <20120330152808.GC28934@google.com> <4F78FE89.2070707@cn.fujitsu.com> <20120402072009.GF30360@redhat.com> <20120402185259.GA16226@dhcp-172-17-108-109.mtv.corp.google.com> <1333392978.2971.25.camel@dabdike> <20120402190045.GC16226@dhcp-172-17-108-109.mtv.corp.google.com> <20120404080149.GC22658@redhat.com> <4F825BE7.80204@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F825BE7.80204@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 09, 2012 at 11:47:51AM +0800, Ren Mingxin wrote: > On 04/04/2012 04:01 PM, Michael S. Tsirkin wrote: > >On Mon, Apr 02, 2012 at 12:00:45PM -0700, Tejun Heo wrote: > >>On Mon, Apr 02, 2012 at 11:56:18AM -0700, James Bottomley wrote: > >>>So if we're agreed no other devices going forwards should ever use this > >>>interface, is there any point unifying the interface? No matter how > >>>many caveats you hedge it round with, putting the API in a central place > >>>will be a bit like a honey trap for careless bears. It might be safer > >>>just to leave it buried in the three current drivers. > >>Yeah, that was my hope but I think it would be easier to enforce to > >>have a common function which is clearly marked legacy so that new > >>driver writers can go look for the naming code in the existing ones, > >>find out they're all using the same function which is marked legacy > >>and explains what to do for newer drivers. > >I think I'm not the only one to be confused about the > >preferred direction here. > >James, do you agree to the approach above? > > > >It would be nice to fix virtio block for 3.4, so > >how about this: > >- I'll just apply the original bugfix patch for 3.4 - > > it only affects virtio > > Sorry, about only affects virtio, I'm not very clear here: > 1) Just duplicate the disk name format function in virtio_blk > like the original patch: https://lkml.org/lkml/2012/3/28/45 So I'd like to apply this, and we can discuss the deduplication for 3.5. Please post a version of this that 1. isn't line-wrapped and doesn't have damaged whitespace so I can run git am on it 2. lists the # of duspported disks correctly as 26^3+(26^2+26) in the description Thanks! > 2) Move the disk name format function into block core like > this patch series but only affects virtio(not affect mtip32xx). > Do you mean the 2) one or something else? > > >- Ren will repost the refactoring patch on top, and we can > > keep up the discussion > > > >Ren if you agree, can you make this a two patch series please? > > > > Sure. > > -- > Thanks, > Ren From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming Date: Mon, 9 Apr 2012 10:50:01 +0300 Message-ID: <20120409075001.GA27771@redhat.com> References: <4F7582B0.5010609@cn.fujitsu.com> <20120330152606.GB28934@google.com> <20120330152808.GC28934@google.com> <4F78FE89.2070707@cn.fujitsu.com> <20120402072009.GF30360@redhat.com> <20120402185259.GA16226@dhcp-172-17-108-109.mtv.corp.google.com> <1333392978.2971.25.camel@dabdike> <20120402190045.GC16226@dhcp-172-17-108-109.mtv.corp.google.com> <20120404080149.GC22658@redhat.com> <4F825BE7.80204@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F825BE7.80204@cn.fujitsu.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Ren Mingxin Cc: Jens Axboe , SCSI , KVM , LKML , VIRTUAL , James Bottomley , Tejun Heo List-Id: linux-scsi@vger.kernel.org On Mon, Apr 09, 2012 at 11:47:51AM +0800, Ren Mingxin wrote: > On 04/04/2012 04:01 PM, Michael S. Tsirkin wrote: > >On Mon, Apr 02, 2012 at 12:00:45PM -0700, Tejun Heo wrote: > >>On Mon, Apr 02, 2012 at 11:56:18AM -0700, James Bottomley wrote: > >>>So if we're agreed no other devices going forwards should ever use this > >>>interface, is there any point unifying the interface? No matter how > >>>many caveats you hedge it round with, putting the API in a central place > >>>will be a bit like a honey trap for careless bears. It might be safer > >>>just to leave it buried in the three current drivers. > >>Yeah, that was my hope but I think it would be easier to enforce to > >>have a common function which is clearly marked legacy so that new > >>driver writers can go look for the naming code in the existing ones, > >>find out they're all using the same function which is marked legacy > >>and explains what to do for newer drivers. > >I think I'm not the only one to be confused about the > >preferred direction here. > >James, do you agree to the approach above? > > > >It would be nice to fix virtio block for 3.4, so > >how about this: > >- I'll just apply the original bugfix patch for 3.4 - > > it only affects virtio > > Sorry, about only affects virtio, I'm not very clear here: > 1) Just duplicate the disk name format function in virtio_blk > like the original patch: https://lkml.org/lkml/2012/3/28/45 So I'd like to apply this, and we can discuss the deduplication for 3.5. Please post a version of this that 1. isn't line-wrapped and doesn't have damaged whitespace so I can run git am on it 2. lists the # of duspported disks correctly as 26^3+(26^2+26) in the description Thanks! > 2) Move the disk name format function into block core like > this patch series but only affects virtio(not affect mtip32xx). > Do you mean the 2) one or something else? > > >- Ren will repost the refactoring patch on top, and we can > > keep up the discussion > > > >Ren if you agree, can you make this a two patch series please? > > > > Sure. > > -- > Thanks, > Ren