All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, stable@vger.kernel.org,
	Andi Kleen <andi@firstfloor.org>, Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] scripts/config: properly report and set string options
Date: Mon, 9 Apr 2012 08:30:06 -0700	[thread overview]
Message-ID: <20120409153006.GA28221@kroah.com> (raw)
In-Reply-To: <1333975750-12154-1-git-send-email-yann.morin.1998@free.fr>

On Mon, Apr 09, 2012 at 02:49:10PM +0200, Yann E. MORIN wrote:
> Currently, scripts/config removes the leading double-quote from
> string options, but leaves the trailing double-quote.
> 
> Also, double-quotes in a string are escaped, but scripts/config
> does not unescape those when printing
> 
> Finally, scripts/config does not escape double-quotes when setting
> string options.
> 
> Eg. the current behavior:
>     $ grep -E '^CONFIG_FOO=' .config
>     CONFIG_FOO="Bar \"Buz\" Meh"
>     $ ./scripts/config -s FOO
>     Bar \"Buz\" Meh"
>     $ ./scripts/config --set-str FOO 'Alpha "Bravo" Charlie'
>     $ grep -E '^CONFIG_FOO=' .config
>     CONFIG_FOO="Alpha "Bravo" Charlie"
> 
> Fix those three, giving this new behavior:
>     $ grep -E '^CONFIG_FOO=' .config
>     CONFIG_FOO="Bar \"Buz\" Meh"
>     $ ./scripts/config -s FOO
>     Bar "Buz" Meh
>     $ ./scripts/config --set-str FOO 'Alpha "Bravo" Charlie'
>     $ grep -E '^CONFIG_FOO=' .config
>     CONFIG_FOO="Alpha \"Bravo\" Charlie"
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: stable@vger.kernel.org

How does this fit the Documentation/stable_kernel_rules.txt
qualification for a patch to be added to the stable releases?

greg k-h

  parent reply	other threads:[~2012-04-09 15:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 12:49 [PATCH] scripts/config: properly report and set string options Yann E. MORIN
2012-04-09 13:22 ` Yann E. MORIN
2012-04-09 14:04 ` Andi Kleen
2012-04-09 15:30 ` Greg KH [this message]
2012-04-09 16:02   ` Yann E. MORIN
2012-04-10  8:57     ` Michal Marek
2012-04-10 13:57     ` Jonathan Nieder
2012-04-10 23:07       ` Yann E. MORIN
2012-04-11  1:33         ` Jonathan Nieder
2012-04-19 21:07 ` Yann E. MORIN
2012-05-15 22:14   ` Michal Marek
2012-05-09 21:27 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120409153006.GA28221@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=stable@vger.kernel.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.