From: Andi Kleen <ak@linux.intel.com>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic()
Date: Mon, 9 Apr 2012 12:36:25 -0700 [thread overview]
Message-ID: <20120409193625.GB28791@tassilo.jf.intel.com> (raw)
In-Reply-To: <4F8333BC.3050509@windriver.com>
> That is an interesting patch series, but I am not sure I agree about the caller propagating a flag to control what you see in panic. I intentionally set CONFIG_DEBUG_VERBOSE=y for a reason, I want a stack trace if and when panic(), oops, BUG, etc... is ever called. This might be a personal preference, but I do not wish to be searching on a string, to find out where the kernel execution terminated. I want to see stack traces all the time, with the exception of the cases you pointed out in the original patch.
The idea was that callers who are calling panic not due to a programming
error (like no root, hardware error etc.) do not print the backtrace.
And only "assert like" panics would.
This makes the screen less cluttered for user or hardware induced
panics.
Besides that it does a couple of related things, like set proper
timeouts.
-Andi
next prev parent reply other threads:[~2012-04-09 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 17:20 [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic() Jason Wessel
2012-04-09 18:34 ` Andi Kleen
2012-04-09 19:08 ` Jason Wessel
2012-04-09 19:36 ` Andi Kleen [this message]
2012-04-10 19:19 ` Andrew Morton
2012-04-10 23:29 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120409193625.GB28791@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.