From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524Ab2DJHR7 (ORCPT ); Tue, 10 Apr 2012 03:17:59 -0400 Received: from mga14.intel.com ([143.182.124.37]:51065 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754318Ab2DJHR6 (ORCPT ); Tue, 10 Apr 2012 03:17:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="129035115" Date: Tue, 10 Apr 2012 10:18:59 +0300 From: Mika Westerberg To: Grant Likely Cc: linux-kernel@vger.kernel.org, linus.walleij@stericsson.com Subject: Re: [PATCH 2/3] gpio: langwell: allocate IRQ descriptors dynamically for SPARSE_IRQ Message-ID: <20120410071859.GA18679@intel.com> References: <1333617317-28437-1-git-send-email-mika.westerberg@linux.intel.com> <1333617317-28437-2-git-send-email-mika.westerberg@linux.intel.com> <20120406043414.3B8FF3E0DD7@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120406043414.3B8FF3E0DD7@localhost> Organization: Intel Finland Oy - BIC 0357606-4 - PL 281, 00181 Helsinki User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 05, 2012 at 09:34:14PM -0700, Grant Likely wrote: > On Thu, 5 Apr 2012 12:15:16 +0300, Mika Westerberg wrote: > > Since x86 is using SPARSE_IRQ by default nowadays it means that we need to > > allocate IRQ descriptors dynamically using irq_alloc_descs() otherwise the > > genirq code fails to convert our irq numbers to suitable descriptors. > > > > Signed-off-by: Mika Westerberg > > Applied, thakns. > > While you're in this driver, you should look at converting to using an > irq_domain for irq <==> hwirq mapping. At the very least, > irq_data->hwirq should be used instead of abusing irq_set_chip_data(). Ok, will do. Thanks.