All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Wei Liu <wei.liu2@citrix.com>, David VomLehn <dvomlehn@cisco.com>,
	Bart Van Assche <bvanassche@acm.org>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v4 0/10] skb paged fragment destructors
Date: Tue, 10 Apr 2012 17:58:47 +0300	[thread overview]
Message-ID: <20120410145845.GF19556@redhat.com> (raw)
In-Reply-To: <1334067965.5394.22.camel@zakaz.uk.xensource.com>

On Tue, Apr 10, 2012 at 03:26:05PM +0100, Ian Campbell wrote:
>               * I can't for the life of me get anything to actually hit
>                 this code path. I've been trying with an NFS server
>                 running in a Xen HVM domain with emulated (e.g. tap)
>                 networking and a client in domain 0, using the NFS fix
>                 in this series which generates SKBs with destructors
>                 set, so far -- nothing. I suspect that lack of TSO/GSO
>                 etc on the TAP interface is causing the frags to be
>                 copied to normal pages during skb_segment().

To enable gso you need to call TUNSETOFFLOAD.

-- 
MST

  parent reply	other threads:[~2012-04-10 14:58 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 14:26 [PATCH v4 0/10] skb paged fragment destructors Ian Campbell
2012-04-10 14:26 ` [PATCH 01/10] net: add and use SKB_ALLOCSIZE Ian Campbell
2012-04-10 14:57   ` Eric Dumazet
2012-04-10 14:57   ` Eric Dumazet
2012-04-10 14:26 ` Ian Campbell
2012-04-10 14:26 ` [PATCH 02/10] net: Use SKB_WITH_OVERHEAD in build_skb Ian Campbell
2012-04-10 14:58   ` Eric Dumazet
2012-04-10 14:58   ` Eric Dumazet
2012-04-10 14:26 ` Ian Campbell
2012-04-10 14:26 ` [PATCH 03/10] chelsio: use SKB_WITH_OVERHEAD Ian Campbell
2012-04-10 14:59   ` Eric Dumazet
2012-04-10 14:59   ` Eric Dumazet
2012-04-10 14:26 ` Ian Campbell
2012-04-10 14:26 ` [PATCH 04/10] net: pad skb data and shinfo as a whole rather than individually Ian Campbell
2012-04-10 15:01   ` Eric Dumazet
2012-04-10 15:01   ` Eric Dumazet
2012-04-10 14:26 ` Ian Campbell
2012-04-10 14:26 ` [PATCH 05/10] net: move destructor_arg to the front of sk_buff Ian Campbell
2012-04-10 14:26 ` Ian Campbell
2012-04-10 15:05   ` Eric Dumazet
2012-04-10 15:19     ` Ian Campbell
2012-04-10 15:19     ` Ian Campbell
2012-04-10 15:05   ` Eric Dumazet
2012-04-10 18:33   ` Alexander Duyck
2012-04-10 18:41     ` Eric Dumazet
2012-04-10 18:41     ` Eric Dumazet
2012-04-10 19:15       ` Alexander Duyck
2012-04-11  8:00         ` Ian Campbell
2012-04-11  8:00         ` Ian Campbell
2012-04-11 16:31           ` Alexander Duyck
2012-04-11 17:00             ` Ian Campbell
2012-04-11 17:00             ` Ian Campbell
2012-04-11 16:31           ` Alexander Duyck
2012-04-11  8:20         ` Eric Dumazet
2012-04-11 16:05           ` Alexander Duyck
2012-04-11 16:05           ` Alexander Duyck
2012-04-11  8:20         ` Eric Dumazet
2012-04-10 19:15       ` Alexander Duyck
2012-04-11  7:56     ` Ian Campbell
2012-04-11  7:56     ` Ian Campbell
2012-04-10 18:33   ` Alexander Duyck
2012-04-10 14:26 ` [PATCH 06/10] net: add support for per-paged-fragment destructors Ian Campbell
2012-04-10 14:26 ` Ian Campbell
2012-04-26 20:44   ` [Xen-devel] " Konrad Rzeszutek Wilk
2012-04-26 20:44   ` Konrad Rzeszutek Wilk
2012-04-10 14:26 ` [PATCH 07/10] net: only allow paged fragments with the same destructor to be coalesced Ian Campbell
2012-04-10 14:26 ` Ian Campbell
2012-04-10 20:11   ` Ben Hutchings
2012-04-10 20:11   ` Ben Hutchings
2012-04-11  7:45     ` Ian Campbell
2012-04-11  7:45     ` Ian Campbell
2012-04-10 14:26 ` [PATCH 08/10] net: add skb_orphan_frags to copy aside frags with destructors Ian Campbell
2012-04-10 14:26 ` Ian Campbell
2012-04-10 14:26 ` [PATCH 09/10] net: add paged frag destructor support to kernel_sendpage Ian Campbell
2012-04-10 14:26 ` [PATCH 10/10] sunrpc: use SKB fragment destructors to delay completion until page is released by network stack Ian Campbell
     [not found] ` <1334067965.5394.22.camel-o4Be2W7LfRlXesXXhkcM7miJhflN2719@public.gmane.org>
2012-04-10 14:26   ` [PATCH 09/10] net: add paged frag destructor support to kernel_sendpage Ian Campbell
2012-04-10 14:26     ` [Ocfs2-devel] " Ian Campbell
2012-04-10 14:26     ` Ian Campbell
2012-04-10 14:26   ` [PATCH 10/10] sunrpc: use SKB fragment destructors to delay completion until page is released by network stack Ian Campbell
2012-04-10 14:26     ` Ian Campbell
2012-04-10 14:58 ` [PATCH v4 0/10] skb paged fragment destructors Michael S. Tsirkin
2012-04-10 14:58 ` Michael S. Tsirkin [this message]
2012-04-10 15:00 ` Michael S. Tsirkin
2012-04-10 15:00 ` Michael S. Tsirkin
2012-04-10 15:46 ` Bart Van Assche
2012-04-10 15:46 ` Bart Van Assche
2012-04-10 15:50   ` Ian Campbell
2012-04-10 15:50   ` Ian Campbell
2012-04-11 10:02     ` Bart Van Assche
2012-04-11 10:02     ` Bart Van Assche
2012-04-10 14:26 Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120410145845.GF19556@redhat.com \
    --to=mst@redhat.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=bvanassche@acm.org \
    --cc=davem@davemloft.net \
    --cc=dvomlehn@cisco.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.