From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: wm9712: Fix build due to missing definition of "runtime"
Date: Tue, 10 Apr 2012 22:38:10 +0100 [thread overview]
Message-ID: <20120410213809.GV7499@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334093587-18184-1-git-send-email-festevam@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 803 bytes --]
On Tue, Apr 10, 2012 at 06:33:07PM -0300, Fabio Estevam wrote:
> Fix the following build error:
>
> sound/soc/codecs/wm9712.c:482:32: error: 'runtime' undeclared (first use in this function)
> sound/soc/codecs/wm9712.c:499:33: error: 'runtime' undeclared (first use in this function)
On second thoughts looking at what the setting is being used for
applied... the code is rather odd here, though.
In general changes like this which make no attempt to understand what
they're changing are a bad idea - don't just cut'n'paste some errors
into your changelog, explain what's gone wrong and why. It's like when
people just initialise a variable to some random value to shut a warning
up without understanding why, the fact that the error goes away doesn't
mean that the fix is sensible.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-04-10 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:33 [PATCH] ASoC: wm9712: Fix build due to missing definition of "runtime" Fabio Estevam
2012-04-10 21:34 ` Mark Brown
2012-04-10 21:38 ` Mark Brown [this message]
2012-04-10 21:48 ` Fabio Estevam
-- strict thread matches above, loose matches on Subject: below --
2012-04-10 21:29 Fabio Estevam
2012-04-10 21:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410213809.GV7499@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.