* [PATCH 1/2] irq_domain: correct the debugfs file name
@ 2012-04-10 12:25 Mika Westerberg
2012-04-10 12:25 ` [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show() Mika Westerberg
2012-04-10 23:26 ` [PATCH 1/2] irq_domain: correct the debugfs file name Grant Likely
0 siblings, 2 replies; 6+ messages in thread
From: Mika Westerberg @ 2012-04-10 12:25 UTC (permalink / raw)
To: linux-kernel; +Cc: tglx, benh, grant.likely, Mika Westerberg
The actual name of the irq_domain mapping debugfs file is
"irq_domain_mapping" not "virq_mapping".
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
kernel/irq/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
index cf1a4a6..d1a758b 100644
--- a/kernel/irq/Kconfig
+++ b/kernel/irq/Kconfig
@@ -62,7 +62,7 @@ config IRQ_DOMAIN_DEBUG
help
This option will show the mapping relationship between hardware irq
numbers and Linux irq numbers. The mapping is exposed via debugfs
- in the file "virq_mapping".
+ in the file "irq_domain_mapping".
If you don't know what this means you don't need it.
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show()
2012-04-10 12:25 [PATCH 1/2] irq_domain: correct the debugfs file name Mika Westerberg
@ 2012-04-10 12:25 ` Mika Westerberg
2012-04-10 23:27 ` Grant Likely
2012-04-10 23:26 ` [PATCH 1/2] irq_domain: correct the debugfs file name Grant Likely
1 sibling, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2012-04-10 12:25 UTC (permalink / raw)
To: linux-kernel; +Cc: tglx, benh, grant.likely, Mika Westerberg
On 32-bit machines reading the /sys/kernel/debug/irq_domain_mapping file
outputs following:
virq hwirq chip name chip data domain name
9 0x00000 IO-APIC 0x c175a0f8 none
10 0x00000 IO-APIC 0x c175a108 none
11 0x00000 IO-APIC 0x c175a118 none
...
which looks a bit funny. Fix that with filling the gap with zeroes instead
of spaces.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
kernel/irq/irqdomain.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 3601f3f..d350c72 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -666,7 +666,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
seq_printf(m, "%-15s ", p);
data = irq_desc_get_chip_data(desc);
- seq_printf(m, "0x%16p ", data);
+ seq_printf(m, "0x%016lx ", (unsigned long)data);
if (desc->irq_data.domain && desc->irq_data.domain->of_node)
p = desc->irq_data.domain->of_node->full_name;
--
1.7.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] irq_domain: correct the debugfs file name
2012-04-10 12:25 [PATCH 1/2] irq_domain: correct the debugfs file name Mika Westerberg
2012-04-10 12:25 ` [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show() Mika Westerberg
@ 2012-04-10 23:26 ` Grant Likely
1 sibling, 0 replies; 6+ messages in thread
From: Grant Likely @ 2012-04-10 23:26 UTC (permalink / raw)
To: Mika Westerberg, linux-kernel; +Cc: tglx, benh, Mika Westerberg
On Tue, 10 Apr 2012 15:25:42 +0300, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> The actual name of the irq_domain mapping debugfs file is
> "irq_domain_mapping" not "virq_mapping".
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied, thanks
.g
> ---
> kernel/irq/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
> index cf1a4a6..d1a758b 100644
> --- a/kernel/irq/Kconfig
> +++ b/kernel/irq/Kconfig
> @@ -62,7 +62,7 @@ config IRQ_DOMAIN_DEBUG
> help
> This option will show the mapping relationship between hardware irq
> numbers and Linux irq numbers. The mapping is exposed via debugfs
> - in the file "virq_mapping".
> + in the file "irq_domain_mapping".
>
> If you don't know what this means you don't need it.
>
> --
> 1.7.9.1
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show()
2012-04-10 12:25 ` [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show() Mika Westerberg
@ 2012-04-10 23:27 ` Grant Likely
2012-04-11 5:47 ` Grant Likely
0 siblings, 1 reply; 6+ messages in thread
From: Grant Likely @ 2012-04-10 23:27 UTC (permalink / raw)
To: Mika Westerberg, linux-kernel; +Cc: tglx, benh, Mika Westerberg
On Tue, 10 Apr 2012 15:25:43 +0300, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> On 32-bit machines reading the /sys/kernel/debug/irq_domain_mapping file
> outputs following:
>
> virq hwirq chip name chip data domain name
> 9 0x00000 IO-APIC 0x c175a0f8 none
> 10 0x00000 IO-APIC 0x c175a108 none
> 11 0x00000 IO-APIC 0x c175a118 none
> ...
>
> which looks a bit funny. Fix that with filling the gap with zeroes instead
> of spaces.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied, thanks.
g.
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 3601f3f..d350c72 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -666,7 +666,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
> seq_printf(m, "%-15s ", p);
>
> data = irq_desc_get_chip_data(desc);
> - seq_printf(m, "0x%16p ", data);
> + seq_printf(m, "0x%016lx ", (unsigned long)data);
>
> if (desc->irq_data.domain && desc->irq_data.domain->of_node)
> p = desc->irq_data.domain->of_node->full_name;
> --
> 1.7.9.1
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show()
2012-04-10 23:27 ` Grant Likely
@ 2012-04-11 5:47 ` Grant Likely
2012-04-11 9:21 ` Mika Westerberg
0 siblings, 1 reply; 6+ messages in thread
From: Grant Likely @ 2012-04-11 5:47 UTC (permalink / raw)
To: Mika Westerberg, linux-kernel; +Cc: tglx, benh, Mika Westerberg
On Tue, 10 Apr 2012 17:27:08 -0600, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Tue, 10 Apr 2012 15:25:43 +0300, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> > On 32-bit machines reading the /sys/kernel/debug/irq_domain_mapping file
> > outputs following:
> >
> > virq hwirq chip name chip data domain name
> > 9 0x00000 IO-APIC 0x c175a0f8 none
> > 10 0x00000 IO-APIC 0x c175a108 none
> > 11 0x00000 IO-APIC 0x c175a118 none
> > ...
> >
> > which looks a bit funny. Fix that with filling the gap with zeroes instead
> > of spaces.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Applied, thanks.
I've dropped this one again. There is actually an easier way to
achieve the same result. By dropping the precision entirely from the
format string the output will always get 0 extended. I'll post an
alternate patch soon.
g.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show()
2012-04-11 5:47 ` Grant Likely
@ 2012-04-11 9:21 ` Mika Westerberg
0 siblings, 0 replies; 6+ messages in thread
From: Mika Westerberg @ 2012-04-11 9:21 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kernel, tglx, benh
On Tue, Apr 10, 2012 at 11:47:28PM -0600, Grant Likely wrote:
>
> I've dropped this one again. There is actually an easier way to
> achieve the same result. By dropping the precision entirely from the
> format string the output will always get 0 extended. I'll post an
> alternate patch soon.
Yeah, that sounds simpler as well. Thanks for fixing it.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-11 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-10 12:25 [PATCH 1/2] irq_domain: correct the debugfs file name Mika Westerberg
2012-04-10 12:25 ` [PATCH 2/2] irq_domain: fix formatting of chip data pointer in virq_debug_show() Mika Westerberg
2012-04-10 23:27 ` Grant Likely
2012-04-11 5:47 ` Grant Likely
2012-04-11 9:21 ` Mika Westerberg
2012-04-10 23:26 ` [PATCH 1/2] irq_domain: correct the debugfs file name Grant Likely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.