From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964845Ab2DKX60 (ORCPT ); Wed, 11 Apr 2012 19:58:26 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:59955 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933969Ab2DKX6W (ORCPT ); Wed, 11 Apr 2012 19:58:22 -0400 Date: Wed, 11 Apr 2012 19:54:44 -0400 (EDT) Message-Id: <20120411.195444.540814653660043985.davem@davemloft.net> To: paul.gortmaker@windriver.com Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, tony@bakeyournoodle.com, mmarek@suse.cz, lacombar@gmail.com Subject: Re: [PATCH 3/5] drivers/net: remove IS_ENABLED usage from wiznet drivers From: David Miller In-Reply-To: <1334188257-3449-4-git-send-email-paul.gortmaker@windriver.com> References: <1334188257-3449-1-git-send-email-paul.gortmaker@windriver.com> <1334188257-3449-4-git-send-email-paul.gortmaker@windriver.com> X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Wed, 11 Apr 2012 16:54:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Gortmaker Date: Wed, 11 Apr 2012 19:50:55 -0400 > The use of IS_ENABLED in C code (vs just in CPP #if directives) > causes us to carry the burden of a huge autoconf.h file. It is > also misleading in that a casual inspection of the code would > leave one thinking that the if statements were evaluated at > runtime, when TX_FLOW is a Kconfig bool and hence evaluated > at configure time as an either/or. > > Signed-off-by: Paul Gortmaker Want me to toss this into net-next?