From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/3] drm/i915: make DP configuration vars less confusing in ironlake_crtc_mode_se Date: Wed, 11 Apr 2012 08:56:51 -0700 Message-ID: <20120411085651.1d33be43@jbarnes-desktop> References: <1334084285-4770-1-git-send-email-jbarnes@virtuousgeek.org> <1334092931_352626@CP5-2952> <20120411095355.GB4296@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0916759084==" Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 51BA19EF6A for ; Wed, 11 Apr 2012 08:56:57 -0700 (PDT) In-Reply-To: <20120411095355.GB4296@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0916759084== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/jtEFPyUaoK5vr0VoMhgFXCw"; protocol="application/pgp-signature" --Sig_/jtEFPyUaoK5vr0VoMhgFXCw Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 11 Apr 2012 11:53:55 +0200 Daniel Vetter wrote: > On Tue, Apr 10, 2012 at 10:22:09PM +0100, Chris Wilson wrote: > > On Tue, 10 Apr 2012 11:58:03 -0700, Jesse Barnes wrote: > > > Both PCH and CPU eDP are DP, so set the is_dp flag to true. Add > > > is_cpu_edp and is_pch_edp bools to make checking for each less verbose > > > (rather than has_edp_encoder && !intel_encoder_is_pch_edp() sprinkled > > > everywhere). And rename the "has_edp_encoder" variable to just > > > "edp_encoder". > > >=20 > > > With the above variables cleaned up, the rest of the code becomes a b= it > > > more readable and clear. > > >=20 > > > Signed-off-by: Jesse Barnes > >=20 > > Ok, that took quite a bit of reading to be sure that the changes were > > consistent. Unfortunately it also looks to be in its simplest form. > >=20 > > Reviewed-by: Chris Wilson > Queued for -next, thanks for the patch. I don't know what to do with the > other two patches, are they supposed to be for -fixes? I don't think they're urgent enough for -fixes. They're still just fixing issues on my IVB SDV. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/jtEFPyUaoK5vr0VoMhgFXCw Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPhanDAAoJEIEoDkX4Qk9h+dkP/03UdSlM2EQux1dJtl9NohxF b9Cqk974AcpPt7OVh2VK669oPEHCPtCeBB3GTdmAmbqhQrE+Gr6N8BWD/fpVXccc BikjumEypkjlivPCr4KF35Ayd+rbnlDpXsixv/Iqbz75CDZ0pHiy58qQ9WLLOctG x4ga7XCQ/0KrhbfjuFhWXwjuWNJwNU3PIzrIpwIgJgS46MYfCXe/X+/TIPJOif78 F68m9OxVRzROJefiCzdEZhstBbuXUSeHa6GKMjXomz0t38o3ZTq/+66phUNW5mh1 MOcCnunWHks9YV/vYEoBBXFoaeEyH/lsX9Es276/gHiFnD04+70r2QrIQA4Uy7kU I6YpV4QiXle8KLNCWTJEXamToifT+sqTqUF6CRZajP1eZN1TUo5yWT+g7y3ni43I 05gVILJh4cHgb6S+xV4QwWE2W1QxQif6sf0GRX6hdcA4OYk7Nr3l/3h2lAUs4WBp RhMe1Z8iKPcCGsSK8DjTed8Vz+Tj0jvfV7lXlm4C+XAItaomoFki+rkzU3MJHiMa 9kuklBpP2OwROaTf0jgrQfODt21SSiSj/8RD6LvxFVcNdOhxonwr8exIC8qtGbVn GASGxqMJ+fDeSw3q51f2DdVRxZPAOoYNmMFYe8lkJEzO1bYV6/AtLLifEyzbjknB dDmV8K0s172QPaSwjQSe =TdjT -----END PGP SIGNATURE----- --Sig_/jtEFPyUaoK5vr0VoMhgFXCw-- --===============0916759084== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0916759084==--