From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Stephen Boyd <bebarino@gmail.com>
Cc: <git@vger.kernel.org>, <spearce@spearce.org>, <szeder@ira.uka.de>,
<felipe.contreras@gmail.com>, <jrnieder@gmail.com>
Subject: Re: [PATCH 2/2] completion: Use parse-options raw output for simple long options
Date: Wed, 11 Apr 2012 15:56:14 +0200 [thread overview]
Message-ID: <20120411135614.GQ2289@goldbirke> (raw)
In-Reply-To: <1334140165-24958-3-git-send-email-bebarino@gmail.com>
Hi,
On Wed, Apr 11, 2012 at 03:29:25AM -0700, Stephen Boyd wrote:
> Now that parse-options supports generating lists of long options for any
> parse-optified git program we can remove the hand-coded lists in the
> completion script. Replace these lists with code to generate the lists
> lazily when a user tab completes that specific command. Unforunately,
> doing lazy evalution takes more lines than before, but the benefit is we
> reduce the amount of trivial patches to update the script for new and/or
> removed options. It also mildly encourages the migration of git commands
> to the parse-options API.
>
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> ---
>
> Is there some way to compute these lists with some magical function instead
> of duplicating that logic over and over?
Maybe a function like this:
__git_compute_command_options ()
{
local varname="__git_${@//[ -]/_}_options"
eval "test -n \"\$$varname\" || $varname=\"$(git $@ --dump-raw-long-options)\""
}
And then in each completion function just need to call this function
with the command (and possibly subcommand) as parameter:
__git_compute_command_options add
Best,
Gábor
next prev parent reply other threads:[~2012-04-11 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 10:29 [PATCH 0/2] Dynamic long options for bash completion Stephen Boyd
2012-04-11 10:29 ` [PATCH 1/2] parse-options: Add support for dumping out long options Stephen Boyd
2012-04-11 10:51 ` Felipe Contreras
2012-04-12 7:42 ` Stephen Boyd
2012-04-11 12:59 ` Jonathan Nieder
2012-04-12 7:02 ` Stephen Boyd
2012-04-11 14:06 ` SZEDER Gábor
2012-04-12 7:12 ` Stephen Boyd
2012-04-15 12:49 ` SZEDER Gábor
2012-04-15 19:23 ` Junio C Hamano
2012-04-11 10:29 ` [PATCH 2/2] completion: Use parse-options raw output for simple " Stephen Boyd
2012-04-11 13:09 ` Jonathan Nieder
2012-04-11 13:56 ` SZEDER Gábor [this message]
2012-04-17 10:44 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411135614.GQ2289@goldbirke \
--to=szeder@ira.uka.de \
--cc=bebarino@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.