Re: [RFC 4/4] drm: Add NVIDIA Tegra support

From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Jon Mayo <jmayo-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [RFC 4/4] drm: Add NVIDIA Tegra support
Date: Wed, 11 Apr 2012 16:11:08 +0200	[thread overview]
Message-ID: <20120411141108.GI27337@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <20120411133512.GL4296-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

* Daniel Vetter wrote:
> On Wed, Apr 11, 2012 at 03:23:26PM +0200, Thierry Reding wrote:
> > * Daniel Vetter wrote:
> > > On Wed, Apr 11, 2012 at 02:10:30PM +0200, Thierry Reding wrote:
> > > > This commit adds a very basic DRM driver for NVIDIA Tegra SoCs. It
> > > > currently has rudimentary GEM support and can run a console on the
> > > > framebuffer as well as X using the xf86-video-modesetting driver.
> > > > Only the RGB output is supported. Quite a lot of things still need
> > > > to be worked out and there is a lot of room for cleanup.
> > > 
> > > Indeed, after a quick look there are tons of functions that are just stubs
> > > ;-) One thing I wonder though is why you directly use the iommu api and
> > > not wrap it up into dma_map? Is arm infrastructure just not there yet or
> > > do you plan to tightly integrate the tegra drm with the iommu (e.g. for
> > > process space switching or similarly funky stuff)?
> > 
> > I'm not sure I know what you are referring to. Looking for all users of
> > iommu_map() doesn't turn up anything related to dma_map. Can you point me in
> > the right direction?
> 
> Well, you use the iommu api to map/unmap memory into the iommu for tegra,
> whereas usually device drivers just use the dma api to do that. The usual
> interface is dma_map_sg/dma_unmap_sg, but there are quite a few variants
> around. I'm just wondering why this you've choosen this.

I don't think this works on ARM. Maybe I'm not seeing the whole picture but
judging by a quick look through the kernel tree there aren't any users that
map DMA memory through an IOMMU.

Maybe your question is answered by my reply to Alan's comment. The mapping
is actually done to get a linear view for the display controller which
doesn't support SG transfers. The kernel and user-space already have virtual
linear buffers.

Perhaps I'm being dense?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]