From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mark A. Greer" Subject: Re: [PATCH 12/12] arm: omap3: am35x: Register davinci_mdio before davinci_emac Date: Wed, 11 Apr 2012 15:00:14 -0700 Message-ID: <20120411220014.GB31197@animalcreek.com> References: <1334171147-7517-1-git-send-email-mgreer@animalcreek.com> <1334171147-7517-13-git-send-email-mgreer@animalcreek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail20.dotsterhost.com ([66.11.232.73]:56884 "EHLO mail20.dotsterhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933301Ab2DKWAP (ORCPT ); Wed, 11 Apr 2012 18:00:15 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, khilman@ti.com, Ilya Yanok On Wed, Apr 11, 2012 at 03:24:05PM -0600, Paul Walmsley wrote: > cc Ilya > > On Wed, 11 Apr 2012, Mark A. Greer wrote: > > > From: "Mark A. Greer" > > > > Problem: > > -------- > > When resuming from a Suspend-to-RAM event, the eth0 device > > (davinci emac/mdio) on am35xx boards wouldn't work and the > > following error message appeared on the console: > > > > "net eth0: could not connect to phy davinci_mdio-0:00" > > ... > > > Signed-off-by: Mark A. Greer > > --- > > arch/arm/mach-omap2/am35xx-emac.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/am35xx-emac.c b/arch/arm/mach-omap2/am35xx-emac.c > > index 1f97e74..d23bd6c 100644 > > --- a/arch/arm/mach-omap2/am35xx-emac.c > > +++ b/arch/arm/mach-omap2/am35xx-emac.c > > This is a little off-topic from this patch, but we should get rid of this > arch/arm/mach-omap2/am35xx-emac.c file. These on-chip devices should be > registered via the hwmod code. Looking at > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c, I don't see any trace of the > EMAC or MDIO in there. That's where all of these IPSS IP blocks should be > declared... Okay, I'll take a look and see what I can do. Mark -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: mgreer@animalcreek.com (Mark A. Greer) Date: Wed, 11 Apr 2012 15:00:14 -0700 Subject: [PATCH 12/12] arm: omap3: am35x: Register davinci_mdio before davinci_emac In-Reply-To: References: <1334171147-7517-1-git-send-email-mgreer@animalcreek.com> <1334171147-7517-13-git-send-email-mgreer@animalcreek.com> Message-ID: <20120411220014.GB31197@animalcreek.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Apr 11, 2012 at 03:24:05PM -0600, Paul Walmsley wrote: > cc Ilya > > On Wed, 11 Apr 2012, Mark A. Greer wrote: > > > From: "Mark A. Greer" > > > > Problem: > > -------- > > When resuming from a Suspend-to-RAM event, the eth0 device > > (davinci emac/mdio) on am35xx boards wouldn't work and the > > following error message appeared on the console: > > > > "net eth0: could not connect to phy davinci_mdio-0:00" > > ... > > > Signed-off-by: Mark A. Greer > > --- > > arch/arm/mach-omap2/am35xx-emac.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/am35xx-emac.c b/arch/arm/mach-omap2/am35xx-emac.c > > index 1f97e74..d23bd6c 100644 > > --- a/arch/arm/mach-omap2/am35xx-emac.c > > +++ b/arch/arm/mach-omap2/am35xx-emac.c > > This is a little off-topic from this patch, but we should get rid of this > arch/arm/mach-omap2/am35xx-emac.c file. These on-chip devices should be > registered via the hwmod code. Looking at > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c, I don't see any trace of the > EMAC or MDIO in there. That's where all of these IPSS IP blocks should be > declared... Okay, I'll take a look and see what I can do. Mark --