From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC 2/4] iommu: tegra/gart: Add device tree support Date: Thu, 12 Apr 2012 08:51:09 +0200 Message-ID: <20120412065108.GC4162@avionic-0098.adnet.avionic-design.de> References: <1334146230-1795-1-git-send-email-thierry.reding@avionic-design.de> <1334146230-1795-3-git-send-email-thierry.reding@avionic-design.de> <4F85BD9D.7050409@wwwdotorg.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2201259864538729482==" Return-path: In-Reply-To: <4F85BD9D.7050409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Stephen Warren Cc: David Airlie , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Olof Johansson , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Colin Cross , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jon Mayo List-Id: linux-tegra@vger.kernel.org --===============2201259864538729482== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="aT9PWwzfKXlsBJM1" Content-Disposition: inline --aT9PWwzfKXlsBJM1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Stephen Warren wrote: > On 04/11/2012 06:10 AM, Thierry Reding wrote: > > This commit adds device tree support for the GART hardware available on > > NVIDIA Tegra 20 SoCs. > >=20 > > Signed-off-by: Thierry Reding > > --- > > arch/arm/boot/dts/tegra20.dtsi | 6 ++++++ > > arch/arm/mach-tegra/board-dt-tegra20.c | 1 + > > drivers/iommu/tegra-gart.c | 10 ++++++++++ > > 3 files changed, 17 insertions(+) >=20 > I think I'd prefer at least the tegra20.dtsi change split out into a > separate patch so I can queue it in a "dt" topic branch in the Tegra repo. >=20 > It might be a good idea to split this into two on an arch/arm vs. > drivers/iommu boundary. Looking at Olof's branches for 3.4, that split > is what happened there. >=20 > Finally, there should be a binding documentation file in > Documentation/devicetree/bindings in order to specify the number of reg > property entries needed, and their meaning, since there's more than 1 > (even though you did comment it nicely in the .dtsi file) Okay, I'll do that. Thierry --aT9PWwzfKXlsBJM1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAk+Ge1wACgkQZ+BJyKLjJp/vYQCgmzAQyon0uJtVYVi1aTW1Ju9z 4e8An3lnj6kmSzAELvSRO/7ryOIGuSQQ =5sDW -----END PGP SIGNATURE----- --aT9PWwzfKXlsBJM1-- --===============2201259864538729482== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommu --===============2201259864538729482==--