From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127Ab2DLHeF (ORCPT ); Thu, 12 Apr 2012 03:34:05 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:40638 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861Ab2DLHeD (ORCPT ); Thu, 12 Apr 2012 03:34:03 -0400 Date: Thu, 12 Apr 2012 10:35:54 +0300 From: Dan Carpenter To: Laxman Dewangan Cc: jic23@cam.ac.uk, gregkh@linuxfoundation.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, jbrenner@taosinc.com, rklein@nvidia.com, max@stro.at, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/2] staging: iio: add driver for isl29028 Message-ID: <20120412073554.GA6498@mwanda> References: <1334214492-23044-1-git-send-email-ldewangan@nvidia.com> <1334214492-23044-2-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1334214492-23044-2-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090205.4F86855D.000B,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 12, 2012 at 12:38:11PM +0530, Laxman Dewangan wrote: > Intersil's ISL29028 is concurrent Ambient Light and > Proximity Sensor device. > Add driver to access the light and IR intensity and > proximity value via iio interface. > > Signed-off-by: Laxman Dewangan > --- > Taken care of all review comment from Dan. Looks nice. You went above and beyond and cleaned up a couple things I didn't mention. Thanks. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH V2 1/2] staging: iio: add driver for isl29028 Date: Thu, 12 Apr 2012 10:35:54 +0300 Message-ID: <20120412073554.GA6498@mwanda> References: <1334214492-23044-1-git-send-email-ldewangan@nvidia.com> <1334214492-23044-2-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1334214492-23044-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, jbrenner-yYKgigLBUwlBDgjK7y7TUQ@public.gmane.org, rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, max-U9r9yeDMy7A@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Apr 12, 2012 at 12:38:11PM +0530, Laxman Dewangan wrote: > Intersil's ISL29028 is concurrent Ambient Light and > Proximity Sensor device. > Add driver to access the light and IR intensity and > proximity value via iio interface. > > Signed-off-by: Laxman Dewangan > --- > Taken care of all review comment from Dan. Looks nice. You went above and beyond and cleaned up a couple things I didn't mention. Thanks. regards, dan carpenter