[PATCH] tools/blktap2: fix 'make clean'

[PATCH] tools/blktap2: fix 'make clean'

[Tim Deegan]

# HG changeset patch
# User Tim Deegan <tim@xen.org>
# Date 1333621466 -3600
# Node ID 4b6bf18b6790e3713ddc4fdc1d63e54b4635c57b
# Parent  d690c7e896a26c54a5ab85458824059de72d5cba
tools/blktap2: fix 'make clean'

Signed-off-by: Tim Deegan <tim@xen.org>

diff -r d690c7e896a2 -r 4b6bf18b6790 tools/blktap2/lvm/Makefile
--- a/tools/blktap2/lvm/Makefile	Thu Apr 05 11:06:03 2012 +0100
+++ b/tools/blktap2/lvm/Makefile	Thu Apr 05 11:24:26 2012 +0100
@@ -27,7 +27,7 @@ lvm-util: lvm-util.o
 	$(CC) -DLVM_UTIL $(LDFLAGS) -o lvm-util lvm-util.c
 
 clean:
-	rm -rf *.o *~ $(DEPS) $(IBIN)
+	rm -rf *.o *.opic *~ $(DEPS) $(IBIN)
 
 .PHONY: all build clean install lvm-util

Re: [PATCH] tools/blktap2: fix 'make clean'

[Ian Campbell]

On Thu, 2012-04-05 at 11:25 +0100, Tim Deegan wrote:
> # HG changeset patch
> # User Tim Deegan <tim@xen.org>
> # Date 1333621466 -3600
> # Node ID 4b6bf18b6790e3713ddc4fdc1d63e54b4635c57b
> # Parent  d690c7e896a26c54a5ab85458824059de72d5cba
> tools/blktap2: fix 'make clean'
> 
> Signed-off-by: Tim Deegan <tim@xen.org>

Somebody reported a build error which looked very much like a symptom of
something not getting cleaned up like this a couple of days ago --
unfortunately I can't remember who or where or I'd cc them.

Anyway: 

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> 
> diff -r d690c7e896a2 -r 4b6bf18b6790 tools/blktap2/lvm/Makefile
> --- a/tools/blktap2/lvm/Makefile	Thu Apr 05 11:06:03 2012 +0100
> +++ b/tools/blktap2/lvm/Makefile	Thu Apr 05 11:24:26 2012 +0100
> @@ -27,7 +27,7 @@ lvm-util: lvm-util.o
>  	$(CC) -DLVM_UTIL $(LDFLAGS) -o lvm-util lvm-util.c
>  
>  clean:
> -	rm -rf *.o *~ $(DEPS) $(IBIN)
> +	rm -rf *.o *.opic *~ $(DEPS) $(IBIN)
>  
>  .PHONY: all build clean install lvm-util
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [PATCH] tools/blktap2: fix 'make clean'

[Tim Deegan]

Ping?

At 11:25 +0100 on 05 Apr (1333625143), Tim Deegan wrote:
> # HG changeset patch
> # User Tim Deegan <tim@xen.org>
> # Date 1333621466 -3600
> # Node ID 4b6bf18b6790e3713ddc4fdc1d63e54b4635c57b
> # Parent  d690c7e896a26c54a5ab85458824059de72d5cba
> tools/blktap2: fix 'make clean'
> 
> Signed-off-by: Tim Deegan <tim@xen.org>
> 
> diff -r d690c7e896a2 -r 4b6bf18b6790 tools/blktap2/lvm/Makefile
> --- a/tools/blktap2/lvm/Makefile	Thu Apr 05 11:06:03 2012 +0100
> +++ b/tools/blktap2/lvm/Makefile	Thu Apr 05 11:24:26 2012 +0100
> @@ -27,7 +27,7 @@ lvm-util: lvm-util.o
>  	$(CC) -DLVM_UTIL $(LDFLAGS) -o lvm-util lvm-util.c
>  
>  clean:
> -	rm -rf *.o *~ $(DEPS) $(IBIN)
> +	rm -rf *.o *.opic *~ $(DEPS) $(IBIN)
>  
>  .PHONY: all build clean install lvm-util
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [PATCH] tools/blktap2: fix 'make clean'

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-devel] [PATCH] tools/blktap2: fix 'make clean'"):
> On Thu, 2012-04-05 at 11:25 +0100, Tim Deegan wrote:
> > # HG changeset patch
> > # User Tim Deegan <tim@xen.org>
> > # Date 1333621466 -3600
> > # Node ID 4b6bf18b6790e3713ddc4fdc1d63e54b4635c57b
> > # Parent  d690c7e896a26c54a5ab85458824059de72d5cba
> > tools/blktap2: fix 'make clean'
> > 
> > Signed-off-by: Tim Deegan <tim@xen.org>
> 
> Somebody reported a build error which looked very much like a symptom of
> something not getting cleaned up like this a couple of days ago --
> unfortunately I can't remember who or where or I'd cc them.
> 
> Anyway: 
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

I have applied this.

Thanks,
Ian.