From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 02/14] drm/i915: set ring->size in common ring setup code Date: Thu, 12 Apr 2012 12:23:47 -0700 Message-ID: <20120412122347.4058cd04@bwidawsk.net> References: <1334175179-1514-1-git-send-email-daniel.vetter@ffwll.ch> <1334175179-1514-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id EFBA39E824 for ; Thu, 12 Apr 2012 12:23:54 -0700 (PDT) In-Reply-To: <1334175179-1514-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, 11 Apr 2012 22:12:47 +0200 Daniel Vetter wrote: > Eventually we want to scale the ring size depending upon available > gtt space. For now just consolidate this instead of replicating it > over all ringbuffer templates. > > Signed-off-by: Daniel Vetter > --- Definitely in the bikeshed category: Why not just make it a macro and scrap the member in struct intel_ring_buffer?