From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC v2] Revive the work on render-nodes branch Date: Thu, 12 Apr 2012 21:55:26 +0300 Message-ID: <20120412185526.GN4917@intel.com> References: <1334254784-3200-1-git-send-email-ihadzic@research.bell-labs.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 41DAA9E776 for ; Thu, 12 Apr 2012 11:55:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1334254784-3200-1-git-send-email-ihadzic@research.bell-labs.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ilija Hadzic Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Apr 12, 2012 at 02:19:25PM -0400, Ilija Hadzic wrote: > The following set of patches is the reword of the series > sent two weeks ago [2] that will revive the drm-render-nodes [1] > branch. Details of the original series are described in [2]. > = > Patches in this series have been reworked (and a few prep patches > have been added) to address the comment about the planes support > (planes can now be included in the resource list for the render > node). > = > Consequently, the ioctls have changed to include plane support > so the libdrm side is also affected (patches for libdrm will be sent > in the series following this one). Didn't have time for a detailed look yet, but at least one thing = missing from your patch set is handling of possible_crtcs and possible_clones for getplane and getencoder ioctls. AFAICT the bits in those are supposed to tell you the index of the object ID in the getresources reply. So when queried via a "render node", some form of remapping must be performed. Also the name "render node" is still very confusing. How about just callling it a partition or something. Or maybe someone could suggest a more self explanatory name for this stuff. -- = Ville Syrj=E4l=E4 Intel OTC