From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/14] drm/i915: set ring->size in common ring setup code Date: Thu, 12 Apr 2012 22:17:27 +0200 Message-ID: <20120412201727.GG3705@phenom.ffwll.local> References: <1334175179-1514-1-git-send-email-daniel.vetter@ffwll.ch> <1334175179-1514-3-git-send-email-daniel.vetter@ffwll.ch> <20120412122347.4058cd04@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 63CE19E744 for ; Thu, 12 Apr 2012 13:16:35 -0700 (PDT) Received: by wibhj13 with SMTP id hj13so1898560wib.12 for ; Thu, 12 Apr 2012 13:16:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120412122347.4058cd04@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 12, 2012 at 12:23:47PM -0700, Ben Widawsky wrote: > On Wed, 11 Apr 2012 22:12:47 +0200 > Daniel Vetter wrote: > > > Eventually we want to scale the ring size depending upon available > > gtt space. For now just consolidate this instead of replicating it > > over all ringbuffer templates. > > > > Signed-off-by: Daniel Vetter > > --- > > Definitely in the bikeshed category: > Why not just make it a macro and scrap the member in struct > intel_ring_buffer? 830/845 need a workaround to reduce the effective ringbuffer size by 2 cachelines. And as alluded in the commit-message, we want to make this slightly more dynamic. All this pipe_control workarounds eat away way too much ringbuffer space :( -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48