From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 14 Apr 2012 15:33:49 +0200
Subject: [U-Boot] [PATCH 4/6] usb:command: Support for USB Download
	command
In-Reply-To: <1334215049-20362-5-git-send-email-l.majewski@samsung.com>
References: <1334215049-20362-1-git-send-email-l.majewski@samsung.com>
	<1334215049-20362-5-git-send-email-l.majewski@samsung.com>
Message-ID: <20120414133349.01ACF20022F@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lukasz Majewski,

In message <1334215049-20362-5-git-send-email-l.majewski@samsung.com> you wrote:
> Support for usbdownload command, which starts USB Downloading process
> compliant with Samsung's THOR protocol.
...
> +static char dnl_tab[4][STR_SIZE];
> +
> +char *find_dnl_entry(char* s, char *name)
...
> +int img_store(struct g_dnl *dnl, int medium)


etc.  Please add sufficient comments that allow to understand what
these functions are supposed to do.

> +int do_usbd_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> +	/* Simple argv[0] passing is not working since 'usbdown' cmd can
> +	   be run by */
> +	/* 'usb', 'usbd' or 'usbdown' */

Incorrect multiline comment style,  and I have to admit that I don;t
understand what you are trying to tell us here.

Also note that "usb" is already in use.

> +	puts("THOR Downloader\n");

Please less verbose (see prvious comments).



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I can call spirits from the vasty deep."
"Why so can I, or so can any man; but will they come when you do call
for them?"          - Shakespeare, 1 King Henry IV, Act III, Scene I.