From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 14 Apr 2012 15:40:09 +0200
Subject: [U-Boot] [PATCH 6/6] usb:g_dnl: Support for g_dnl download usb
	gadget for TRATS board
In-Reply-To: <1334215049-20362-7-git-send-email-l.majewski@samsung.com>
References: <1334215049-20362-1-git-send-email-l.majewski@samsung.com>
	<1334215049-20362-7-git-send-email-l.majewski@samsung.com>
Message-ID: <20120414134009.AB14620022F@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lukasz Majewski,

In message <1334215049-20362-7-git-send-email-l.majewski@samsung.com> you wrote:
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>

See comments as for GONI board.

> +#ifdef CONFIG_USBDOWNLOAD_GADGET
> +void usbd_thor_udc_probe(void)
> +{
> +	puts("USB_udc_probe\n");
> +	s3c_udc_probe(&s5pc210_otg_data);
> +}
> +#endif

Duplicated code.  Please move to common location and avoid
duplication.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I think there's a world market for about five computers.
         -- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943