From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 14 Apr 2012 15:46:46 +0200
Subject: [U-Boot] [PATCH 2/4] usb:gadget:composite: Linux
	composite.{h/c} code adjustement for u-boot
In-Reply-To: <1334214931-19480-3-git-send-email-l.majewski@samsung.com>
References: <1334214931-19480-1-git-send-email-l.majewski@samsung.com>
	<1334214931-19480-3-git-send-email-l.majewski@samsung.com>
Message-ID: <20120414134646.D366120022F@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lukasz Majewski,

In message <1334214931-19480-3-git-send-email-l.majewski@samsung.com> you wrote:
> This commit fixes Linux kernel's composite.{h/c} code to work with u-boot.

You mean you added non-working code first, and fix it later?  This is
not bisectable.  Please squash.

> -/* #define VERBOSE_DEBUG */
> +#define VERBOSE_DEBUG

NAK.  Please use standard debug() faclities.

> -#include <linux/kallsyms.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/device.h>
> +/* #include <linux/kallsyms.h> */
> +/* #include <linux/kernel.h> */
> +/* #include <linux/slab.h> */
> +/* #include <linux/device.h> */

Please remove dead code.  Fix globally.

> +	     ({ char *speed;

Indentation by TAB only.

>  /*
> + * Linux kernel compatibility layer
> + */

NAK.  It makes no sense to add this here, on such a low level.

If this is considered useful or even necessary, it should be added with
global scope and visibility.

I rather tend to ask to clean up the code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The number you have dialed is imaginary. Please divide by 0  and  try
again.