From: Herbert Xu <herbert@gondor.apana.org.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [0/3] bridge: Do not send multicast queries by default
Date: Sun, 15 Apr 2012 19:13:00 +0800 [thread overview]
Message-ID: <20120415111300.GA14147@gondor.apana.org.au> (raw)
In-Reply-To: <20120413.105345.319552552748408545.davem@davemloft.net>
On Fri, Apr 13, 2012 at 10:53:45AM -0400, David Miller wrote:
> From: Herbert Xu <herbert@gondor.hengli.com.au>
> Date: Fri, 13 Apr 2012 20:36:41 +0800
>
> > (incidentally, I noticed that our IPv6 code has been "fixed" to not
> > use zero source addresses, which is wrong as we may end up being THE
> > MLD querier in a network).
>
> I seem to recall it was explicitly changed to be this way and that
> there was a good reason for this, see the history.
Right, the reason given is that RFC2710 (for MLD) requires the
source address to be a link-local address.
However, we're not implementing an RFC2710 node here. What we're
doing is better described by RFC4541 (IGMP/MLD snooping), which calls
for the use of a zero source address for both IPv4 and IPv6.
The reason is precisely because it's invalid for normal querier
nodes and as such they would ignore us (rather than elect us
and potentially disrupt things).
Now granted we may also end up having other nodes ignoring our
queries where we'd rather that they answered us with reports.
However, this isn't as bad because the whole querying mechanism
in the snooping code is merely an optimisation to speed up
convergence primarily during start-up. So if we don't see the
reports straight away it's not a deal-breaker.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2012-04-15 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 12:36 [0/3] bridge: Do not send multicast queries by default Herbert Xu
2012-04-13 12:37 ` [PATCH 1/3] bridge: Add br_multicast_start_querier Herbert Xu
2012-04-13 12:37 ` [PATCH 3/3] bridge: Add multicast_querier toggle and disable queries by default Herbert Xu
2012-04-13 12:37 ` [PATCH 2/3] bridge: Restart queries when last querier expires Herbert Xu
2012-04-13 14:53 ` [0/3] bridge: Do not send multicast queries by default David Miller
2012-04-15 11:13 ` Herbert Xu [this message]
2012-04-15 16:50 ` David Miller
2013-04-03 15:28 ` Linus Lüssing
2012-04-15 16:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120415111300.GA14147@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.