From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 25/29] drm/i915: detect digital outputs on
 Haswell
Date: Mon, 16 Apr 2012 01:36:02 +0200
Message-ID: <20120415233602.GD3982@phenom.ffwll.local>
References: <1334347745-11743-1-git-send-email-eugeni.dodonov@intel.com>
	<1334347745-11743-26-git-send-email-eugeni.dodonov@intel.com>
	<1334351837_416057@CP5-2952>
	<CAC7Lmns5OLWyfhhRetjhB+uJAnKFOtiD5k5wvL2FpuvhFOZzMg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id E42D79E738
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 15 Apr 2012 16:35:07 -0700 (PDT)
Received: by wgbdr12 with SMTP id dr12so3855200wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 15 Apr 2012 16:35:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAC7Lmns5OLWyfhhRetjhB+uJAnKFOtiD5k5wvL2FpuvhFOZzMg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 13, 2012 at 09:37:44PM -0300, Eugeni Dodonov wrote:
> On Fri, Apr 13, 2012 at 18:17, Chris Wilson <chris@chris-wilson.co.uk>wrote:
> 
> > We're starting to get to ridiculous levels of indention. Break the PCH
> > detection of SDVO/HDMI outputs into its own routine, and perhaps further
> > down in architectures?
> >
> 
> Yes, both intel_display and intel_hdmi get too overcomplex with those
> patches :(.
> 
> I haven't done the split in those series because I thought that the plan
> was to land those VLV/HSW patches before doing the big display refactoring
> we discussed some weeks ago. But I could certainly start doing it.
> 
> Daniel, what do you think would best from your dinq maintainership point of
> view - refactor those bits here and in other big patches of this series
> (fdi and hdmi ones) and then resend all the patches; or have them as is and
> do the big refactoring for everything after that?

I this specific case I think we simply need to add an IS_HASWELL check
before the HAS_PCH_SPLIT check - hsw shares zero output detection code in
this block with previous pch_split chips, so the indentation seems to be
pointless.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48