From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 16 Apr 2012 16:01:27 +0200
Subject: [U-Boot] [PATCH 2/4] usb:gadget:composite: Linux
	composite.{h/c} code adjustement for u-boot
In-Reply-To: <20120416112308.00700f08@lmajewski.digital.local>
References: <1334214931-19480-1-git-send-email-l.majewski@samsung.com>
	<1334214931-19480-3-git-send-email-l.majewski@samsung.com>
	<20120414134646.D366120022F@gemini.denx.de>
	<20120416112308.00700f08@lmajewski.digital.local>
Message-ID: <20120416140127.4DE62202AAD@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lukasz Majewski,

In message <20120416112308.00700f08@lmajewski.digital.local> you wrote:
> 
> I'm a bit confused about the policy with porting files:
> 
> http://www.denx.de/wiki/U-Boot/Patches
> 
> This says clearly: document from where the code comes from.
> I wanted to show from where the file has been taken.

This is perfectly fine.

> Those files doesn't compile as is, but no one enabled them in u-boot,
> so code is still bisectable. 

You must not expect that Linux kernel code can be used _unchanged_ for
U-Boot's purposes.  Adding a ton of #defines that make no sense in
U-Boot context at all is misleading at best.

> For me it would be even better to provide one commit providing
> composite driver :-), but I wanted to stick to the policy.

Please strip down the driver and remove the parts that do not fit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Boykottiert Microsoft - Kauft Eure Fenster bei OBI!