From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751089Ab2DPP7f (ORCPT ); Mon, 16 Apr 2012 11:59:35 -0400 Received: from mga03.intel.com ([143.182.124.21]:58376 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699Ab2DPP7e (ORCPT ); Mon, 16 Apr 2012 11:59:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="131504019" Date: Mon, 16 Apr 2012 18:08:24 +0200 From: Samuel Ortiz To: Lars-Peter Clausen Cc: linux-kernel@vger.kernel.org, Srinidhi Kasagar , Linus Walleij Subject: Re: [PATCH 3/4] mfd: Remove redundant spi driver bus initialization Message-ID: <20120416160824.GL24130@sortiz-mobl> References: <1334091089-10138-1-git-send-email-lars@metafoo.de> <1334091089-10138-3-git-send-email-lars@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1334091089-10138-3-git-send-email-lars@metafoo.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lars-Peter, On Tue, Apr 10, 2012 at 10:51:28PM +0200, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register() so > we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // > > Signed-off-by: Lars-Peter Clausen > Cc: Samuel Ortiz > Cc: Srinidhi Kasagar > Cc: Linus Walleij Looks good, patch applied to my for-next branch. Thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/