From: Samuel Ortiz <sameo@linux.intel.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: linux-kernel@vger.kernel.org,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Alan Cox <alan@linux.intel.com>,
grant.likely@secretlab.ca, linus.walleij@stericsson.com
Subject: Re: [PATCH V3 1/2] mfd: Add driver for STA2X11 MFD block
Date: Mon, 16 Apr 2012 20:05:53 +0200 [thread overview]
Message-ID: <20120416180553.GV24130@sortiz-mobl> (raw)
In-Reply-To: <99e873520a5e9278abfaaf9fbd514bab2c326479.1334219874.git.rubini@gnudd.com>
Hi Alessandro,
On Thu, Apr 12, 2012 at 10:48:44AM +0200, Alessandro Rubini wrote:
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 29f463c..c194c67 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -873,6 +873,12 @@ config MFD_RC5T583
> Additional drivers must be enabled in order to use the
> different functionality of the device.
>
> +config MFD_STA2X11
> + bool "STA2X11 multi function device support"
> + depends on STA2X11
> + select MFD_CORE
> + select GPIO_STA2X11
So you haven't fixed that one:
- You should not select GPIO_STA2X11 as this won't select the STA2X211 gpio
driver dependencies for you. So if you build this driver with GPIOLIB=n then
your build will fail.
- Why would this one depend on STA2X11 ? I see that you're calling
sta2x11_get_instance() from this driver but I wonder if you could simply
replace the mfd->instance pointer with one pointing to the pci_dev. Not
depending on STA2X11 at all gives you the benefit of a much larger build
coverage from linux-next for example.
> +/* Bar 0 */
> +enum bar0_cells {
> + GPIO_0 = 0,
> + GPIO_1,
> + GPIO_2,
> + GPIO_3,
> + SCTL,
> + SCR,
> + TIME,
> +};
Please protect those ones with a proper namespace.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-04-16 17:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 8:48 [PATCH V3 0/2] MFD and GPIO for STA2X11 Alessandro Rubini
2012-04-12 8:48 ` [PATCH V3 1/2] mfd: Add driver for STA2X11 MFD block Alessandro Rubini
2012-04-16 18:05 ` Samuel Ortiz [this message]
2012-04-16 18:11 ` Alessandro Rubini
2012-05-09 13:37 ` Samuel Ortiz
2012-04-12 8:48 ` [PATCH V3 2/2] gpio: add STA2X11 GPIO block Alessandro Rubini
2012-04-12 15:05 ` Linus Walleij
2012-04-13 11:44 ` Alessandro Rubini
2012-04-13 12:32 ` Linus Walleij
2012-04-13 16:34 ` Linus Walleij
2012-05-09 13:40 ` Samuel Ortiz
2012-05-11 23:34 ` Grant Likely
2012-05-14 7:25 ` Alessandro Rubini
2012-05-14 9:47 ` Mark Brown
2012-05-14 9:51 ` Alessandro Rubini
2012-05-14 9:58 ` Mark Brown
2012-05-14 10:06 ` Alessandro Rubini
2012-05-14 10:08 ` Mark Brown
2012-05-18 9:10 ` Samuel Ortiz
2012-04-16 17:55 ` [PATCH V3 0/2] MFD and GPIO for STA2X11 Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416180553.GV24130@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=giancarlo.asnaghi@st.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.