All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Ondrej Zary <linux@rainbow-software.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/4] Add Wolfson Microelectronics WM8776 codec ALSA driver
Date: Tue, 17 Apr 2012 17:50:06 +0100	[thread overview]
Message-ID: <20120417165005.GR6652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hlilupbe5.wl%tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

On Tue, Apr 17, 2012 at 06:32:18PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > What makes you cleaim that "ASoC was not designed to be used with sound
> > cards"?  Implementing sound cards is the sole purpose of ASoC...

> You don't need to overreact, he surely means only about the existing
> ice1724 sound driver for his device :)

Possibly...  it's really not clear.

> Restructuring ice1712 and ice1724 drivers to use ASoC would require
> quite a lot of works, and no one really wants it, I guess.  Many
> boards are old and can't be tested easily.  And, we still need to
> match the ASoC components with the controls of the current driver.

> This was already discussed a bit, and Clemens suggested like this
> way.

This isn't just adding something into a specific driver which fails at
abstraction, it's adding generic code.  If it were adding something to
the ice17xx driver then that'd be one thing but look at the subject line
and location of the file...  this stuff should be buried inside the
driver if it's too painful to make the driver sane.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-04-17 16:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 21:18 [RFC PATCH 0/4] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary
2012-04-16 21:18 ` [PATCH 1/4] snd-ice1712: add chip_exit callback Ondrej Zary
2012-04-16 21:18 ` [PATCH 2/4] Add Wolfson Microelectronics WM8766 codec ALSA driver Ondrej Zary
2012-04-17 14:59   ` Mark Brown
2012-04-17 16:35     ` Ondrej Zary
2012-04-17 16:54       ` Mark Brown
2012-04-16 21:18 ` [PATCH 3/4] Add Wolfson Microelectronics WM8776 " Ondrej Zary
2012-04-17 15:02   ` Mark Brown
2012-04-17 16:13     ` Ondrej Zary
2012-04-17 16:18       ` Mark Brown
2012-04-17 16:32         ` [alsa-devel] " Takashi Iwai
2012-04-17 16:32           ` Takashi Iwai
2012-04-17 16:50           ` Mark Brown [this message]
2012-04-17 16:52             ` [alsa-devel] " Takashi Iwai
2012-04-17 16:52               ` Takashi Iwai
2012-04-17 17:04               ` [alsa-devel] " Mark Brown
2012-04-17 18:06                 ` Takashi Iwai
2012-04-17 18:15                   ` Ondrej Zary
2012-04-17 18:15                     ` Ondrej Zary
2012-04-17 18:22                     ` [alsa-devel] " Mark Brown
2012-04-17 18:22                       ` Mark Brown
2012-04-17 19:14                       ` [alsa-devel] " Takashi Iwai
2012-04-17 19:43                         ` Mark Brown
2012-04-17 19:43                           ` Mark Brown
2012-04-17 20:16                           ` Pavel Hofman
2012-04-17 21:29                             ` Mark Brown
2012-04-18  9:06                               ` Mark Brown
2012-04-18  9:27                                 ` Pavel Hofman
2012-04-18 10:34                                   ` Mark Brown
2012-04-17 19:12                     ` [alsa-devel] " Takashi Iwai
2012-04-17 21:07                       ` Ondrej Zary
2012-04-17 21:07                         ` Ondrej Zary
2012-04-18  5:54                         ` [alsa-devel] " Takashi Iwai
2012-04-18  5:54                           ` Takashi Iwai
2012-04-18  6:52                           ` [alsa-devel] " Clemens Ladisch
2012-04-18  6:52                             ` Clemens Ladisch
2012-04-16 21:18 ` [PATCH 4/4] snd-ice1712: Add Philips PSC724 Ultimate Edge Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120417165005.GR6652@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.