All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/18] xfs: Do background CIL flushes via a workqueue
Date: Wed, 18 Apr 2012 11:47:06 +1000	[thread overview]
Message-ID: <20120418014706.GM6734@dastard> (raw)
In-Reply-To: <20120417214956.GB16881@sgi.com>

On Tue, Apr 17, 2012 at 04:49:56PM -0500, Ben Myers wrote:
> On Tue, Apr 17, 2012 at 04:21:55PM -0500, Ben Myers wrote:
> > Gah! I just hit this assert.  
> > 
> > v3.4-rc2-3-g8a00ebe with:
> > Christoph's ilock series
> > Christoph's xfsbufd series
> > Jan's freeze series
> > Dave's queue.
> > 
> > nfs7 login: [ 1175.172406] XFS: Assertion failed: push_seq > 0 && push_seq <= ctx->sequence, file: /root/xfs/fs/xfs/xfs_log_cil.c, line: 406

which has probably resulted in a log corruption.

> [  390.097633] ---[ end trace 33a9795b638157b9 ]---
> 
> Here it is from the system log
> 
> Apr 17 16:35:12 linux kernel: [  389.637543] XFS (264=211361P۔300): Mounting Filesystem
> Apr 17 16:35:12 linux kernel: [  389.912402] XFS (264=211361P۔300): Starting recovery (logdev: internal)
> Apr 17 16:35:12 linux kernel: [  390.054357] XFS (264=211361P۔300): xlog_recover_inode_pass2: Bad inode magic number, dip = 0xf0ffd800, dino bp = 0xef89c480, ino = 25541592
> Apr 17 16:35:12 linux kernel: [  390.066290] XFS (264=211361P۔300): Internal error xlog_recover_inode_pass2(1) at line 2248 of file /root/xfs/fs/xfs/xfs_log_recover.c.  Caller 0xfaa08ffa

Because log recovery has read a bad inode from disk, which means an
allocation transaction has probably not been replayed.

....

> Apr 17 16:35:12 linux kernel: [  390.082084] XFS (264=211361P۔300): log mount/recovery failed: error 117
> Apr 17 16:35:12 linux kernel: [  390.082209] XFS (264=211361P۔300): log mount failed
> Apr 17 16:35:12 linux kernel: [  390.082217] XFS: Assertion failed: atomic_read(&pag->pag_ref) == 0, file: /root/xfs/fs/xfs/xfs_mount.c, line: 272
> 
> Apr 17 16:35:12 linux kernel: [  390.092542] ------------[ cut here ]------------
> Apr 17 16:35:12 linux kernel: [  390.097004] kernel BUG at /root/xfs/fs/xfs/xfs_message.c:101!
> Apr 17 16:35:12 linux kernel: [  390.097004] invalid opcode: 0000 [#1] PREEMPT SMP 
> Apr 17 16:35:12 linux kernel: [  390.097004] Modules linked in: xfs(O) exportfs af_packet dm_mod e1000 e100 sr_mod shpchp iTCO_wdt cdrom i2c_i801 e7xxx_edac iTCO_vendor_support sg floppy pci_hotplug serio_raw button edac_core pcspkr autofs4 processor thermal_sys ata_generic
> Apr 17 16:35:12 linux kernel: [  390.097004] 
> Apr 17 16:35:12 linux kernel: [  390.097004] Pid: 5217, comm: mount Tainted: G           O 3.4.0-rc2-1.2-desktop+ #15 TYAN Computer Corp. S2721-533 Thunder i7501 Pro/S2721-533 Thunder i7501 Pro
> Apr 17 16:35:12 linux kernel: [  390.097004] EIP: 0060:[<fa9b8d56>] EFLAGS: 00010286 CPU: 3
> Apr 17 16:35:12 linux kernel: [  390.097004] EIP is at assfail+0x26/0x30 [xfs]
> Apr 17 16:35:12 linux kernel: [  390.097004] EAX: 0000007b EBX: f0f87680 ECX: 000000f3 EDX: 00000046
> Apr 17 16:35:12 linux kernel: [  390.097004] ESI: 00000000 EDI: f1d089a8 EBP: f1d67ddc ESP: f1d67dc8
> Apr 17 16:35:12 linux kernel: [  390.097004]  DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> Apr 17 16:35:12 linux kernel: [  390.097004] CR0: 8005003b CR2: b7735580 CR3: 2ff82000 CR4: 000007f0
> Apr 17 16:35:12 linux kernel: [  390.097004] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
> Apr 17 16:35:12 linux kernel: [  390.097004] DR6: ffff0ff0 DR7: 00000400
> Apr 17 16:35:12 linux kernel: [  390.097004] Process mount (pid: 5217, ti=f1d66000 task=f0d99060 task.ti=f1d66000)
> Apr 17 16:35:12 linux kernel: [  390.097004] Stack:
> Apr 17 16:35:12 linux kernel: [  390.097004]  00000000 faa31844 faa399d4 faa41a7f 00000110 f1d67df8 faa0b125 f1d0899c
> Apr 17 16:35:12 linux kernel: [  390.097004]  f1d08800 00000075 f1d08800 00000014 f1d67e50 faa0dfe9 f1d08800 faa41c34
> Apr 17 16:35:12 linux kernel: [  390.097004]  00005000 ef82b700 fa9aea50 f1d67e24 f1d08acc 00000000 00000002 00000003
> Apr 17 16:35:12 linux kernel: [  390.097004] Call Trace:
> Apr 17 16:35:12 linux kernel: [  390.097004]  [<faa0b125>] xfs_free_perag+0x75/0xa0 [xfs]
> Apr 17 16:35:12 linux kernel: [  390.097004]  [<faa0dfe9>] xfs_mountfs+0x2d9/0x710 [xfs]
> Apr 17 16:35:12 linux kernel: [  390.097004]  [<fa9aea50>] ? _xfs_filestream_pick_ag+0x1b0/0x1b0 [xfs]
> Apr 17 16:35:12 linux kernel: [  390.097004]  [<fa9bb5d6>] xfs_fs_fill_super+0x196/0x240 [xfs]
> Apr 17 16:35:12 linux kernel: [  390.097004]  [<c031ce72>] mount_bdev+0x172/0x1b0
> Apr 17 16:35:12 linux kernel: [  390.097004]  [<fa9b965a>] xfs_fs_mount+0x1a/0x20 [xfs]

And that's a different problem that Eric tripped over a couple of
weeks ago, but hasn't sent a new patch to fix:

http://oss.sgi.com/archives/xfs/2012-04/msg00035.html
http://oss.sgi.com/archives/xfs/2012-04/msg00115.html

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-04-18  1:47 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 12:10 [PATCH 0/18] xfs: current patch queue Dave Chinner
2012-04-13 12:10 ` [PATCH 01/18] xfs: Ensure inode reclaim can run during quotacheck Dave Chinner
2012-04-13 18:01   ` Mark Tinguely
2012-04-29 21:37   ` Christoph Hellwig
2012-04-13 12:10 ` [PATCH 02/18] xfs: pass shutdown method into xfs_trans_ail_delete_bulk Dave Chinner
2012-04-13 17:40   ` Mark Tinguely
2012-04-13 23:04     ` Dave Chinner
2012-04-13 23:38       ` [PATCH 02/18 V2] " Dave Chinner
2012-04-16 18:49         ` Mark Tinguely
2012-04-13 12:10 ` [PATCH 03/18] xfs: Do background CIL flushes via a workqueue Dave Chinner
2012-04-17 17:54   ` Mark Tinguely
2012-04-17 21:21   ` Ben Myers
2012-04-17 21:49     ` Ben Myers
2012-04-18  1:47       ` Dave Chinner [this message]
2012-04-30  1:24         ` Dave Chinner
2012-04-30  6:09           ` Dave Chinner
2012-04-18  1:58     ` Dave Chinner
2012-04-13 12:10 ` [PATCH 04/18] xfs: page type check in writeback only checks last buffer Dave Chinner
2012-04-16 16:15   ` Mark Tinguely
2012-04-29 21:39   ` Christoph Hellwig
2012-04-30  0:29     ` Dave Chinner
2012-04-13 12:10 ` [PATCH 05/18] xfs: Use preallocation for inodes with extsz hints Dave Chinner
2012-04-13 16:45   ` Mark Tinguely
2012-04-16 15:59   ` Mark Tinguely
2012-04-13 12:10 ` [PATCH 06/18] xfs: fix buffer lookup race on allocation failure Dave Chinner
2012-04-13 18:32   ` Mark Tinguely
2012-04-13 12:10 ` [PATCH 07/18] xfs: check for buffer errors before waiting Dave Chinner
2012-04-13 17:56   ` Mark Tinguely
2012-04-13 12:10 ` [PATCH 08/18] xfs: fix incorrect b_offset initialisation Dave Chinner
2012-04-13 12:10 ` [PATCH 09/18] xfs: use kmem_zone_zalloc for buffers Dave Chinner
2012-04-13 12:10 ` [PATCH 10/18] xfs: clean up buffer get/read call API Dave Chinner
2012-04-13 12:10 ` [PATCH 11/18] xfs: kill b_file_offset Dave Chinner
2012-04-13 12:10 ` [PATCH 12/18] xfs: use blocks for counting length of buffers Dave Chinner
2012-04-13 12:10 ` [PATCH 13/18] xfs: use blocks for storing the desired IO size Dave Chinner
2012-04-13 12:10 ` [PATCH 14/18] xfs: kill xfs_buf_btoc Dave Chinner
2012-04-13 12:10 ` [PATCH 15/18] xfs: kill XBF_LOCK Dave Chinner
2012-04-13 21:20   ` Mark Tinguely
2012-04-13 12:10 ` [PATCH 16/18] xfs: kill xfs_read_buf() Dave Chinner
2012-04-13 12:11 ` [PATCH 17/18] xfs: kill XBF_DONTBLOCK Dave Chinner
2012-04-16 14:34   ` Mark Tinguely
2012-04-13 12:11 ` [PATCH 18/18] xfs: use iolock on XFS_IOC_ALLOCSP calls Dave Chinner
2012-04-16 15:10   ` Mark Tinguely
2012-04-16 21:29 ` [PATCH 0/18] xfs: current patch queue Ben Myers
2012-04-17  4:12   ` Dave Chinner
2012-04-17 14:44     ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418014706.GM6734@dastard \
    --to=david@fromorbit.com \
    --cc=bpm@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.