From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/4] drm/i915: IBX+ doesn't have separate
 vsync/hsync controls on the VGA DAC
Date: Wed, 18 Apr 2012 09:36:09 +0200
Message-ID: <20120418073609.GA5315@phenom.ffwll.local>
References: <1334161416-11775-1-git-send-email-jbarnes@virtuousgeek.org>
	<1334161416-11775-2-git-send-email-jbarnes@virtuousgeek.org>
	<20120411183631.GP4296@phenom.ffwll.local>
	<20120417150633.3af364f5@jbarnes-desktop>
	<1334701145_15395@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id B00E29E74F
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 18 Apr 2012 00:35:17 -0700 (PDT)
Received: by werp11 with SMTP id p11so5501229wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 18 Apr 2012 00:35:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1334701145_15395@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 17, 2012 at 11:18:46PM +0100, Chris Wilson wrote:
> On Tue, 17 Apr 2012 15:06:33 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > Like this?
> > 
> > From fee9f6fbf2230f96b9195baf32fd67b243969a14 Mon Sep 17 00:00:00 2001
> > From: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date: Wed, 11 Apr 2012 09:23:34 -0700
> > Subject: [PATCH] drm/i915: IBX+ doesn't have separate vsync/hsync controls on
> >  the VGA DAC
> > 
> > When the PCH split occurred, we dropped support for separate hsync and
> > vsync disable in the VGA DAC.  So add a PCH specific DPMS function that
> > just uses the port enable bit for controlling DPMS states.
> > 
> > Before this fix, when anything other than a full DPMS off occurred,
> > the VGA port would be left enabled and scanning out while all the other
> > heads would turn off as expected.
> > 
> > v2: duplicate encoder helper vtable into pch and gmch versions (Daniel)
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> With s/intel_crt_dpms/gmch_crt_dpms/ and
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48491
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for next with the gmch_ color applied, thanks for the patch&review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48