From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915/sprite: Avoid incurring extra vblank stall when updating plane on IVB Date: Wed, 18 Apr 2012 09:23:46 -0700 Message-ID: <20120418092346.46cd7d4d@jbarnes-desktop> References: <1334765546-733-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id BABEFA0B9E for ; Wed, 18 Apr 2012 09:23:49 -0700 (PDT) In-Reply-To: <1334765546-733-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 18 Apr 2012 17:12:26 +0100 Chris Wilson wrote: > IvyBridge requires an extra frame between disabling the low power > watermarks and enabling scaling on the sprite plane. If the scaling > is already enabled, then we have already disabled the low power > watermarks and need not incur an extra wait. > > Similarly, as we disable the scaling when turning off the sprite plane, > we can update the scaling enabled flag and restore the low power > watermarks. > > Signed-off-by: Chris Wilson > Cc: Jesse Barnes > --- Yep, this is a good optimization. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center