From: Andrew Morton <akpm@linux-foundation.org>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: Pawel Moll <pawel.moll@arm.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Rusty Russell <rusty@rustcorp.com.au>,
Stanislaw Gruszka <sgruszka@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: fix bug where environment vars can't be passed via boot args
Date: Thu, 19 Apr 2012 15:17:46 -0700 [thread overview]
Message-ID: <20120419151746.8c765ea7.akpm@linux-foundation.org> (raw)
In-Reply-To: <201204061711.q36HBpAh015060@lab-41.internal.tilera.com>
On Fri, 6 Apr 2012 12:53:50 -0400
Chris Metcalf <cmetcalf@tilera.com> wrote:
> Commit 026cee0086f had the side-effect of dropping the '=' from
> the unknown boot arguments that are passed to init as environment
> variables. This is because parse_args() puts a NUL in the string
> where the '=' was when it passes the "param" and "val" pointers
> to the parsing subfunctions. Previously, unknown_bootoption() was
> the last parse_args() subfunction to run, and it carefully put back
> the '=' character. Now ignore_unknown_bootoption() is the last
> one to run, and it wasn't doing the necessary repair, so the
> envp params ended up with the embedded NUL and were no longer
> seen as valid environment variables by init.
This patch has been stuck in your tree for a week or two. The copy
there is missing Woody's Tested-by and (I suspect) his Reported-by and
Pawel's Acked-by.
And because that patch is already in linux-next, I can't (or rather
don't want to) merge it myself.
It needs to be merged into 3.4. Please fix up the changelog data and
send it in?
next prev parent reply other threads:[~2012-04-19 22:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 16:53 [PATCH] init: fix bug where environment vars can't be passed via boot args Chris Metcalf
2012-04-07 20:29 ` Woody Suwalski
2012-04-10 13:15 ` Pawel Moll
2012-04-19 22:17 ` Andrew Morton [this message]
2012-04-20 13:41 ` Chris Metcalf
2012-04-26 19:54 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419151746.8c765ea7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.