From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756516Ab2DTCTX (ORCPT ); Thu, 19 Apr 2012 22:19:23 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41865 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372Ab2DTCTV (ORCPT ); Thu, 19 Apr 2012 22:19:21 -0400 X-Sasl-enc: MnYYkEp0wqxThuro9avYo4wCN15eg2kcR2ipimv1H1Tv 1334888360 Date: Thu, 19 Apr 2012 19:19:18 -0700 From: Greg KH To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke Subject: Re: linux-next: build failure after merge of the driver-core tree Message-ID: <20120420021918.GA16697@kroah.com> References: <20120419144815.50f7c3d30d88e6259665313d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120419144815.50f7c3d30d88e6259665313d@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2012 at 02:48:15PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the driver-core tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > lib/klist.c: In function 'klist_iter_init_node': > lib/klist.c:287:4: error: too few arguments to function 'kref_put' > include/linux/kref.h:92:19: note: declared here > > Caused by commit a15d49fd3094 ("driver core: check start node in > klist_iter_init_node"). That really hasn't been build tested, has it? > > I have used the driver-core tree from next-20120418 for today. Ok, that was just totally obviously broken, I have no idea how that passed my testing, as it just failed right now. So I've reverted it. Hannes, care to fix this up and resend when it works? thanks, greg k-h