Re: [PATCH v8 1/6] Extcon (external connector): import Android's switch class and modify.

From: Greg KH <gregkh@linuxfoundation.org>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: "MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>, NeilBrown <neilb@suse.de>,
	"Randy Dunlap" <rdunlap@xenotime.net>,
	"Mike Lockwood" <lockwood@android.com>,
	"Arve Hjønnevag" <arve@android.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Morten CHRISTIANSEN" <morten.christiansen@stericsson.com>,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
	"John Stultz" <john.stultz@linaro.org>,
	"Joerg Roedel" <joerg.roedel@amd.com>,
	myungjoo.ham@gmail.com, cw00.choi@samsung.com
Subject: Re: [PATCH v8 1/6] Extcon (external connector): import Android's switch class and modify.
Date: Thu, 19 Apr 2012 20:32:09 -0700	[thread overview]
Message-ID: <20120420033209.GA17930@kroah.com> (raw)
In-Reply-To: <CAH9JG2XvYqa7W-PTbq6JrY3LGoFqKkdBfcGJ73HbynqM9ZvhjQ@mail.gmail.com>

On Fri, Apr 20, 2012 at 12:08:32PM +0900, Kyungmin Park wrote:
> On 4/20/12, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Apr 20, 2012 at 11:57:26AM +0900, Kyungmin Park wrote:
> >> On 4/20/12, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> > On Fri, Apr 20, 2012 at 11:46:25AM +0900, Kyungmin Park wrote:
> >> >> On 4/20/12, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> >> > On Thu, Apr 19, 2012 at 11:41:33AM +0900, MyungJoo Ham wrote:
> >> >> >> External connector class (extcon) is based on and an extension of
> >> >> >> Android kernel's switch class located at linux/drivers/switch/.
> >> >> >
> >> >> > Oh come on, this still breaks the build, it is as if you didn't even
> >> >> > test this at all, or modify anything since I reported it as a problem
> >> >> > to
> >> >> > you yesterday:
> >> >> >
> >> >> > drivers/extcon/extcon_class.c:79:6: error: redefinition of
> >> >> > ‘extcon_set_state’
> >> >> > include/linux/extcon.h:80:20: note: previous definition of
> >> >> > ‘extcon_set_state’ was here
> >> >> > drivers/extcon/extcon_class.c:170:5: error: redefinition of
> >> >> > ‘extcon_dev_register’
> >> >> > include/linux/extcon.h:67:19: note: previous definition of
> >> >> > ‘extcon_dev_register’ was here
> >> >> > drivers/extcon/extcon_class.c:214:6: error: redefinition of
> >> >> > ‘extcon_dev_unregister’
> >> >> > include/linux/extcon.h:73:20: note: previous definition of
> >> >> > ‘extcon_dev_unregister’ was here
> >> >> >
> >> >> > You can do better than this, I know you can.
> >> >>
> >> >> Umm. can you show your EXTCON config? I think you build it as module.
> >> >> it's tested it extcon on or not. anyway I'll test it as module and
> >> >> check it.
> >> >
> >> > Yes, I selected to build it as a module, which, according to your patch,
> >> > is a valid selection.
> >>
> >> Found, need to add CONFIG_EXTCON_MODULE at below.
> >
> > You do know we have a new macro that handles all of this for you,
> > IS_ENABLED().  It handles the _MODULE stuff and the other stuff as well,
> > and you can put it in a .c expression also.
> >
> > Try using that instead.
> 
> No problem, send patches with it.
> 
> BTW, can we post it after one hour?

You can send it whenever you want, I do not impose any deadlines.

But note, I'll not be reading email for at least 10 more hours, it's
getting late in my timezone, so take your time and get it right, no
rush.

thanks,

greg k-h