From: Dan Carpenter <dan.carpenter@oracle.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: Frederic Weisbecker <fweisbec@gmail.com>, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>, Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] tracing: Remove an unneeded check Date: Fri, 20 Apr 2012 09:31:45 +0300 [thread overview] Message-ID: <20120420063145.GA22649@elgon.mountain> (raw) memcpy() returns a pointer to "bug". Hopefully, it's not NULL here or we would already have Oopsed. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index ed7b5d1..c2d5b71 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -629,7 +629,6 @@ ssize_t trace_seq_to_user(struct trace_seq *s, char __user *ubuf, size_t cnt) static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt) { int len; - void *ret; if (s->len <= s->readpos) return -EBUSY; @@ -637,9 +636,7 @@ static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt) len = s->len - s->readpos; if (cnt > len) cnt = len; - ret = memcpy(buf, s->buffer + s->readpos, cnt); - if (!ret) - return -EFAULT; + memcpy(buf, s->buffer + s->readpos, cnt); s->readpos += cnt; return cnt;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: Frederic Weisbecker <fweisbec@gmail.com>, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>, Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] tracing: Remove an unneeded check Date: Fri, 20 Apr 2012 06:31:45 +0000 [thread overview] Message-ID: <20120420063145.GA22649@elgon.mountain> (raw) memcpy() returns a pointer to "bug". Hopefully, it's not NULL here or we would already have Oopsed. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index ed7b5d1..c2d5b71 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -629,7 +629,6 @@ ssize_t trace_seq_to_user(struct trace_seq *s, char __user *ubuf, size_t cnt) static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt) { int len; - void *ret; if (s->len <= s->readpos) return -EBUSY; @@ -637,9 +636,7 @@ static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt) len = s->len - s->readpos; if (cnt > len) cnt = len; - ret = memcpy(buf, s->buffer + s->readpos, cnt); - if (!ret) - return -EFAULT; + memcpy(buf, s->buffer + s->readpos, cnt); s->readpos += cnt; return cnt;
next reply other threads:[~2012-04-20 6:32 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-20 6:31 Dan Carpenter [this message] 2012-04-20 6:31 ` [patch] tracing: Remove an unneeded check Dan Carpenter 2012-04-20 13:51 ` Steven Rostedt 2012-04-20 13:51 ` Steven Rostedt 2012-04-20 14:03 ` Dan Carpenter 2012-04-20 14:03 ` Dan Carpenter 2012-04-20 14:26 ` Steven Rostedt 2012-04-20 14:26 ` Steven Rostedt 2012-05-02 21:02 ` [tip:perf/core] tracing: Remove an unneeded check in trace_seq_buffer() tip-bot for Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120420063145.GA22649@elgon.mountain \ --to=dan.carpenter@oracle.com \ --cc=eduard.munteanu@linux360.ro \ --cc=fweisbec@gmail.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.