From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 20 Apr 2012 11:11:48 +0200
Subject: [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440).
	Documentation about the product can be found on:
	http://www.friendlyarm.net/products/mini2440
In-Reply-To: <CABi8O6ZmDcZW66BaEeaSwWibQCJ7kTC2imoLKft7WkCJ6HtuRg@mail.gmail.com>
References: <20120416174633.GA7463@debian> <201204200022.43671.marex@denx.de>
	<CABi8O6ZmDcZW66BaEeaSwWibQCJ7kTC2imoLKft7WkCJ6HtuRg@mail.gmail.com>
Message-ID: <201204201111.48803.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Ilya Averyanov,

[...]

> > > > > > > .word 0x32
> > > > > > > +    .word 0x30
> > > > > > > +    .word 0x30
> > > > > > 
> > > > > > What this undocumented stuff?
> > > > > 
> > > > > SoC specific, I pasted it from smdk2410, it's for initialize the
> > 
> > DRAM.
> > 
> > > > Can't you init DRAM in some more fitting place? Also document this?
> > > 
> > > I don't know, this part is a bit difficult for me, but I'm going to try
> > > to document it with the help of the SoC documentation.
> > > 
> > > For the place, should I move it to mini2440.c in arch_cpu_init() or
> > > board_early_init_f() ? I don't really know the difference.
> > 
> > dram_init() maybe ?
> 
> You propose to initialize the SDRAM controller in dram_init ()?

Well yes, ain't it more fitting ?

Best regards,
Marek Vasut