From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 04/10] drm/i915: drop polled waits from
 i915_wait_request
Date: Sat, 21 Apr 2012 09:14:14 -0700
Message-ID: <20120421091414.12ce6fb0@bwidawsk.net>
References: <1334971412-4826-1-git-send-email-ben@bwidawsk.net>
	<1334971412-4826-5-git-send-email-ben@bwidawsk.net>
	<1335000600_11229@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9744F9E955
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 21 Apr 2012 09:15:43 -0700 (PDT)
In-Reply-To: <1335000600_11229@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Sat, 21 Apr 2012 10:29:35 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Fri, 20 Apr 2012 18:23:26 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > The only time irq_get should fail is during unload or suspend. Both
> > of these points should try to quiesce the GPU before disabling
> > interrupts and so the atomic polling should never occur.
> > 
> > This was recommended by Chris Wilson as a way of reducing added
> > complexity to the polled wait which I introduced in an RFC patch.
> > 
> > 09:57 < ickle_> it's only there as a fudge for waiting after irqs
> > after uninstalled during s&r, we aren't actually meant to hit it
> > 09:57 < ickle_> so maybe we should just kill the code there and fix
> > the breakage
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
> > ---
> 
> > +		if (WARN_ON(!ring->irq_get(ring)))
> > +			return -EBUSY;
> 
> I think this is now a -ENODEV; :)
> -Chris
> 
Got it. Thanks.