From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752808Ab2DVVfh (ORCPT ); Sun, 22 Apr 2012 17:35:37 -0400 Received: from smtp.snhosting.dk ([87.238.248.203]:39840 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506Ab2DVVfg (ORCPT ); Sun, 22 Apr 2012 17:35:36 -0400 Date: Sun, 22 Apr 2012 23:35:35 +0200 From: Sam Ravnborg To: Mark Salter Cc: Mike Frysinger , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexander Viro , Aurelien Jacquiot , Arnd Bergmann Subject: Re: [PATCH] C6X: add support to build with BINFMT_ELF_FDPIC Message-ID: <20120422213534.GA6570@merkur.ravnborg.org> References: <1334958476-6296-1-git-send-email-msalter@redhat.com> <1335129679.12741.4.camel@deneb.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1335129679.12741.4.camel@deneb.redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > > --- a/fs/Kconfig.binfmt > > > +++ b/fs/Kconfig.binfmt > > > > > > config BINFMT_ELF_FDPIC > > > bool "Kernel support for FDPIC ELF binaries" > > > default y > > > - depends on (FRV || BLACKFIN || (SUPERH32 && !MMU)) > > > + depends on (FRV || BLACKFIN || (SUPERH32 && !MMU) || TMS320C6X) > > > > shouldn't the main arch symbol be "C6X" to match arch/c6x/ ? > > It probably should have been. Most architectures use that convention but > there are notable exceptions like powerpc and sh. Please do not repeat past mistakes. It should be trivial to fix. Allow TMS320C6X for a sinel relase along with C6X - and drop it when all users outside your arch has switched over. Sam