All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] EXYNOS: draw 32bpp bitmap TIZEN logo
Date: Mon, 23 Apr 2012 11:22:16 +0200	[thread overview]
Message-ID: <20120423092216.603FF200261@gemini.denx.de> (raw)
In-Reply-To: <4F94B49E.5020802@samsung.com>

Dear Donghwa Lee,

In message <4F94B49E.5020802@samsung.com> you wrote:
> This patches support drawing 32bpp bitmap TIZEN logo in exynos fb.
> asm/arch/trats_logo.h data is compressed by zip and decomressed at 
> the exynos fb driver.
> 
> And vl_bpix of vidinfo_t is changed proper value for u-boot.
> 
> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
> Signed-off-by: Kyungmin park <kyungmin.park@samsung.com>
> ---
>  arch/arm/include/asm/arch-exynos/trats_logo.h | 5070 +++++++++++++++++++++++++
>  board/samsung/trats/trats.c                   |    2 +-
>  drivers/video/exynos_fb.c                     |   40 +-
>  drivers/video/exynos_fimd.c                   |    6 +-
>  include/configs/trats.h                       |    4 +-
>  5 files changed, 5116 insertions(+), 6 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-exynos/trats_logo.h
> 
> diff --git a/arch/arm/include/asm/arch-exynos/trats_logo.h b/arch/arm/include/asm/arch-exynos/trats_logo.h
> new file mode 100644
> index 0000000..a595abd
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-exynos/trats_logo.h

This is not a good location for the logo data.  Either this is vendor
specific, in which place it should go to the vendor directory, or it's
board specific, in which case it should go into the board directory.

In no case I want to have this in arch/arm/include/

thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Remember, there's a big difference between kneeling down and  bending
over.                                                   - Frank Zappa

  parent reply	other threads:[~2012-04-23  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  1:47 [U-Boot] [PATCH 2/2] EXYNOS: draw 32bpp bitmap TIZEN logo Donghwa Lee
2012-04-23  9:00 ` Minkyu Kang
2012-04-23 10:16   ` Donghwa Lee
2012-04-23 10:56     ` Minkyu Kang
2012-04-23  9:22 ` Wolfgang Denk [this message]
2012-04-24  2:17   ` Donghwa Lee
2012-04-24 15:39 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423092216.603FF200261@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.