From: Dan Carpenter <dan.carpenter@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: md/bitmap: move some fields of 'struct bitmap' into a 'storage' substruct.
Date: Mon, 23 Apr 2012 13:17:04 +0300 [thread overview]
Message-ID: <20120423101704.GA20058@mwanda> (raw)
In-Reply-To: <20120423101049.633d9be7@notabene.brown>
On Mon, Apr 23, 2012 at 10:10:49AM +1000, NeilBrown wrote:
> On Fri, 20 Apr 2012 16:13:36 +0300 Dan Carpenter <dan.carpenter@ORACLE.COM>
> > 1210 if (test_and_clear_page_attr(bitmap, j,
> > 1211 BITMAP_PAGE_NEEDWRITE)) {
> > 1212 write_page(bitmap, bitmap->storage.filemap[j], 0);
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^
> > Renamed dereference.
>
> There is a relationship between storage.filemap and storage.file_pages.
> If the later is 0, the former must be non-NULL.
>
> This dereference only happens if file_pages > 0... Maybe I should check
> file_pages up above so as not to confuse smatch??
>
False positives are not really a problem. I only look at new
warnings. My dream is that someday Smatch will be able to figure
out the code flow as it is.
regards,
dan carpenter
prev parent reply other threads:[~2012-04-23 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 13:13 md/bitmap: move some fields of 'struct bitmap' into a 'storage' substruct Dan Carpenter
2012-04-23 0:10 ` NeilBrown
2012-04-23 10:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423101704.GA20058@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.