From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/3] ARM: tegra: Add AHB driver Date: Mon, 23 Apr 2012 18:32:15 +0000 Message-ID: <201204231832.16268.arnd@arndb.de> References: <1335181043-15348-1-git-send-email-hdoyu@nvidia.com> <201204231233.09423.arnd@arndb.de> <4F9598AD.2030308@wwwdotorg.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F9598AD.2030308-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Hiroshi DOYU , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Colin Cross , Olof Johansson , Russell King , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Monday 23 April 2012, Stephen Warren wrote: > I don't know whether it has to be early, but if this driver isn't going > to be instantiated from device tree, I'd prefer it to be initialized by > an explicit function call from the boards or common code rather than an > initcall. It seems a lot easier to keep track of all the initialization > by doing it explicitly. That said, it's quite possible this API couuld > be called from say init_machine instead of init_early though. Having it called from init_machine sounds ok, as long as it still scans the device tree for the addresses rather than hardcoding. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553Ab2DWSci (ORCPT ); Mon, 23 Apr 2012 14:32:38 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:62897 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943Ab2DWScg (ORCPT ); Mon, 23 Apr 2012 14:32:36 -0400 From: Arnd Bergmann To: Stephen Warren Subject: Re: [PATCH 1/3] ARM: tegra: Add AHB driver Date: Mon, 23 Apr 2012 18:32:15 +0000 User-Agent: KMail/1.12.2 (Linux/3.3.0-rc1; KDE/4.3.2; x86_64; ; ) Cc: Hiroshi DOYU , linux-tegra@vger.kernel.org, Colin Cross , Olof Johansson , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1335181043-15348-1-git-send-email-hdoyu@nvidia.com> <201204231233.09423.arnd@arndb.de> <4F9598AD.2030308@wwwdotorg.org> In-Reply-To: <4F9598AD.2030308@wwwdotorg.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201204231832.16268.arnd@arndb.de> X-Provags-ID: V02:K0:9XD1Y/vl1ukHt09TaFTGRcKgwAFZygU1QMpcWoSfrlV 10mP10MImeBI3aGffoxXQ0WyEK+gT1icXpKkncdNHLgqYTIh+N gXfjX+MG1Sk7//TQr2pP291SwsMrZkE0vRFYMYqRwilCWplmgV ZESVt8rGc0HGaRqp84z1IplOGKmghHwS+dRwiWyHrqZrTGjUFr Te9ZZqAtDiVzsa9LNF7cE+i8JtGPpZmXymAU19tHGXbpwQBBmw yRcCvveb3NpEQvMBm4S2LKSRqIbvmdKpsXbNuX6ihO2YkUVhGx 2NG/5BK7vdidxyHIAeYbLySx6cChB4EzeN7gU/N1d/JTlAHxds TTZNBmMGFdRLURtJD6e4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 23 April 2012, Stephen Warren wrote: > I don't know whether it has to be early, but if this driver isn't going > to be instantiated from device tree, I'd prefer it to be initialized by > an explicit function call from the boards or common code rather than an > initcall. It seems a lot easier to keep track of all the initialization > by doing it explicitly. That said, it's quite possible this API couuld > be called from say init_machine instead of init_early though. Having it called from init_machine sounds ok, as long as it still scans the device tree for the addresses rather than hardcoding. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 23 Apr 2012 18:32:15 +0000 Subject: [PATCH 1/3] ARM: tegra: Add AHB driver In-Reply-To: <4F9598AD.2030308@wwwdotorg.org> References: <1335181043-15348-1-git-send-email-hdoyu@nvidia.com> <201204231233.09423.arnd@arndb.de> <4F9598AD.2030308@wwwdotorg.org> Message-ID: <201204231832.16268.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 23 April 2012, Stephen Warren wrote: > I don't know whether it has to be early, but if this driver isn't going > to be instantiated from device tree, I'd prefer it to be initialized by > an explicit function call from the boards or common code rather than an > initcall. It seems a lot easier to keep track of all the initialization > by doing it explicitly. That said, it's quite possible this API couuld > be called from say init_machine instead of init_early though. Having it called from init_machine sounds ok, as long as it still scans the device tree for the addresses rather than hardcoding. Arnd