From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: create macros to handle masked bits Date: Tue, 24 Apr 2012 09:12:36 -0700 Message-ID: <20120424091236.6b3fc509@jbarnes-desktop> References: <1335269052-18582-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id 55DECA0A8D for ; Tue, 24 Apr 2012 09:12:42 -0700 (PDT) In-Reply-To: <1335269052-18582-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Apr 2012 14:04:12 +0200 Daniel Vetter wrote: > ... and put them to so good use. > > Note that there's functional change in vlv clock gating code, we now > no longer spuriously read back the current value of the bit. According > to Bspec the high bits should always read zeror, so ORing this in > should have no effect. > > Cc: Jesse Barnes > Signed-Off-by: Daniel Vetter > --- Looks nice. Now we just have to be vigilant about people using it. :) Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center