From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 3/4] omap3isp: ccdc: Add crop support on output formatter source pad
Date: Tue, 24 Apr 2012 18:14:20 +0300 [thread overview]
Message-ID: <20120424151420.GC7913@valkosipuli.localdomain> (raw)
In-Reply-To: <14838654.TrzCLImese@avalon>
Hi Laurent,
On Tue, Apr 24, 2012 at 11:08:12AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Tuesday 24 April 2012 01:23:06 Sakari Ailus wrote:
> > Hi Laurent,
> >
> > The patch looks good as such on the first glance, but I have another
> > question: why are you not using the selections API instead? It's in
> > Mauro's tree already.
>
> You're totally right, we need to convert the selection API. The reason why
> I've implemented crop support at the CCDC output was simply that I needed it
> for a project and didn't have time to implement the selection API. As the code
> works, I considered it would be good to have it upstream until we switch to
> the selection API.
"Until we switch to the selection API"? The subdev selection API is in
Mauro's tree already so I see no reason not to use it. Implementing new
functionality in a driver using API we've just marked obsolete is... not
pretty.
The compatibility code for the old crop ioctls exist, too, so you get
exactly the same functionality as well.
> > Also, the old S_CROP IOCTL only has been defined for sink pads, not source.
>
> We're already using crop on source pads on sensors ;-)
Is that supposed to work? At the very least least it does not follow the
spec.
Kind regards,
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk
next prev parent reply other threads:[~2012-04-24 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 11:29 [PATCH 0/4] Miscellaneous OMAP3 ISP fixes and enhancements Laurent Pinchart
2012-04-23 11:29 ` [PATCH 1/4] omap3isp: preview: Rename last occurences of *_rgb_to_ycbcr to *_csc Laurent Pinchart
2012-04-23 11:29 ` [PATCH 2/4] omap3isp: preview: Add support for greyscale input Laurent Pinchart
2012-04-24 23:19 ` Sakari Ailus
2012-04-23 11:29 ` [PATCH 3/4] omap3isp: ccdc: Add crop support on output formatter source pad Laurent Pinchart
2012-04-23 22:23 ` Sakari Ailus
2012-04-24 9:08 ` Laurent Pinchart
2012-04-24 15:14 ` Sakari Ailus [this message]
2012-04-24 20:10 ` Laurent Pinchart
2012-04-24 20:46 ` Sakari Ailus
2012-04-23 11:29 ` [PATCH 4/4] omap3isp: Mark probe and cleanup functions with __devinit and __devexit Laurent Pinchart
2012-04-24 23:05 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424151420.GC7913@valkosipuli.localdomain \
--to=sakari.ailus@iki.fi \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.