From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/3] acpi_video: Intel video is not always i915
Date: Wed, 25 Apr 2012 12:31:52 +0100 [thread overview]
Message-ID: <20120425113152.GA8667@srcf.ucam.org> (raw)
In-Reply-To: <20120425112711.613a3cf9@pyramind.ukuu.org.uk>
On Wed, Apr 25, 2012 at 11:27:11AM +0100, Alan Cox wrote:
> On Tue, 24 Apr 2012 23:30:22 +0100
> Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > Right now you seem to set opregion unconditionally on PVR, which seems
> > to be equivalent to the 0xfc check that was there before - I can
> > understand excluding i740, but the PVR check could be left with the gen
> > hardware one?
>
> Not really - they are two drivers. If you build with i915 and not GMA500
> you need the opregion for one and the acpi fallback for the other, and
> vice versa. So we have to check both CONFIG_xxx macro sets.
>
> Right now GMA500 needs the ACPI video stuff never to be enabled on some
> machines. Until we've got full opregion support in the driver that won't
> change.
opregion always seems to be set to 1 if is_gma_pvr() is true, which
means we'll now never bind the acpi video driver on PVR hardware. If
that's what you want, why distinguish between PVR and GEN?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-04-25 11:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 15:44 [PATCH 1/3] acpi_video: fix leaking PCI references Alan Cox
2012-04-24 15:45 ` [PATCH 2/3] acpi_video: Intel video is not always i915 Alan Cox
2012-04-24 21:02 ` Matthew Garrett
2012-04-24 22:31 ` Alan Cox
2012-04-24 22:30 ` Matthew Garrett
2012-04-25 10:27 ` Alan Cox
2012-04-25 11:31 ` Matthew Garrett [this message]
2012-04-25 12:24 ` Alan Cox
2012-04-25 12:40 ` Matthew Garrett
2012-04-25 12:49 ` Alan Cox
2012-04-25 12:48 ` Matthew Garrett
2012-04-24 15:45 ` [PATCH 3/3] gma500: don't register the ACPI video bus Alan Cox
2012-04-25 13:33 [PATCH 1/3] acpi_video: fix leaking PCI references Alan Cox
2012-04-25 13:33 ` [PATCH 2/3] acpi_video: Intel video is not always i915 Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425113152.GA8667@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=airlied@linux.ie \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.