From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 08/12] drm/i915: HWSTAM is only 16-bit on gen3 Date: Wed, 25 Apr 2012 13:50:35 -0700 Message-ID: <20120425135035.7c589f11@jbarnes-desktop> References: <1335304792-17636-1-git-send-email-chris@chris-wilson.co.uk> <1335304792-17636-8-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id 0E7E3A08BA for ; Wed, 25 Apr 2012 13:50:38 -0700 (PDT) In-Reply-To: <1335304792-17636-8-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Apr 2012 22:59:48 +0100 Chris Wilson wrote: > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 878f1c3..a4e074e 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -2307,7 +2307,7 @@ static void i915_irq_preinstall(struct drm_device * dev) > I915_WRITE(PORT_HOTPLUG_STAT, I915_READ(PORT_HOTPLUG_STAT)); > } > > - I915_WRITE(HWSTAM, 0xeffe); > + I915_WRITE16(HWSTAM, 0xeffe); > for_each_pipe(pipe) > I915_WRITE(PIPESTAT(pipe), 0); > I915_WRITE(IMR, 0xffffffff); > @@ -2505,7 +2505,7 @@ static void i915_irq_uninstall(struct drm_device * dev) > I915_WRITE(PORT_HOTPLUG_STAT, I915_READ(PORT_HOTPLUG_STAT)); > } > > - I915_WRITE(HWSTAM, 0xffffffff); > + I915_WRITE16(HWSTAM, 0xffff); > for_each_pipe(pipe) > I915_WRITE(PIPESTAT(pipe), 0); > I915_WRITE(IMR, 0xffffffff); Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center