From mboxrd@z Thu Jan 1 00:00:00 1970 From: djwong Subject: Re: [RFC] jbd2: reduce the number of writes when commiting a transacation Date: Wed, 25 Apr 2012 13:34:34 -0700 Message-ID: <20120425203434.GB6938@tux1.beaverton.ibm.com> References: <20120420110627.GA30373@gmail.com> <20120423022505.GA7855@gmail.com> <67060CC0-9F64-40ED-9467-572996ECF21F@whamcloud.com> <20120423221948.GA6938@tux1.beaverton.ibm.com> <20120424194108.GI18865@thunk.org> Reply-To: djwong@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andreas Dilger , Zheng Liu , Andreas Dilger , "linux-ext4@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" To: "Ted Ts'o" Return-path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:41972 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758823Ab2DYUen (ORCPT ); Wed, 25 Apr 2012 16:34:43 -0400 Received: from /spool/local by e5.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Apr 2012 16:34:42 -0400 Content-Disposition: inline In-Reply-To: <20120424194108.GI18865@thunk.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Apr 24, 2012 at 03:41:08PM -0400, Ted Ts'o wrote: > On Mon, Apr 23, 2012 at 10:19:48PM +0000, djwong wrote: > > > > My huge checksum patchset _does_ include checksums for data blocks; see the > > t_checksum field in struct journal_block_tag_s. iirc the corresponding journal > > replay modifications will skip over corrupt data blocks and keep going. > > I need to check for this in the patches (and you may be doing this > already), but in the kernel failed checksums should result in an > ext4_error() call which will set the file system as corrupt and > needing to be checked. And in e2fsck it should force a full check of > the file system. I'm fairly sure the kernel patch doesn't do that, I think it just skips the block and moves on. As for e2fsck... what does one do inside e2fsck to force a full check? Is that just the equivalent of passing -f? --D > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >