From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Tim Deegan <tim@xen.org>
Cc: Keir Fraser <keir.xen@gmail.com>,
"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
"stefano.stabellini@eu.citrix.com"
<stefano.stabellini@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [hybrid]: code review for function mapping pfn to foreign mfn
Date: Thu, 26 Apr 2012 11:18:48 -0700 [thread overview]
Message-ID: <20120426111848.34e43e75@mantra.us.oracle.com> (raw)
In-Reply-To: <20120426090847.GA67043@ocelot.phlegethon.org>
On Thu, 26 Apr 2012 10:08:47 +0100
Tim Deegan <tim@xen.org> wrote:
> At 16:06 -0700 on 24 Apr (1335283603), Mukesh Rathor wrote:
> > On Tue, 24 Apr 2012 10:36:26 +0100
> > Tim Deegan <tim@xen.org> wrote:
> >
> > > At 18:37 -0700 on 23 Apr (1335206229), Mukesh Rathor wrote:
> > > > On Thu, 19 Apr 2012 15:15:27 +0100
> > > > Tim Deegan <tim@xen.org> wrote:
> >
> > >you still have this mapping. You should take a PGT_writeable_page
> > >typecount, too, if the foreign domain isn't in paging_mode_external
> >
> > Ok, I've it as:
> > if (paging_mode_external(fdom)) {
> > if (get_page_from_pagenr(mfn, fdom) == 0)
> > failed = 1;
> > } else {
> > if (get_page_and_type_from_pagenr(mfn, PGT_writable_page,
> > fdom,0,0)) failed = 1;
> > }
> >
> > But then later fails when it tries to pin the page,
> > MMUEXT_PIN_L4_TABLE, from the lib at:
>
> What's trying to pin an l4 table? I thought your hybrid dom0 didn't
> use the PV MMU.
>
> Tim.
Right, hybrid doesn't use PV mmu.
Here, xl/xc is building a pv guest while running on *hybrid* dom0.
As a result, privcmd is calling this function to map
foreign mfns to pfns:
xc_dom_x86.c:
arch_setup_bootlate -> pin_table -> xc_mmuext_op().
thanks,
Mukesh
next prev parent reply other threads:[~2012-04-26 18:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 1:29 [hybrid]: code review for function mapping pfn to foreign mfn Mukesh Rathor
2012-04-16 13:53 ` Ian Campbell
2012-04-16 14:02 ` Tim Deegan
2012-04-17 1:53 ` Mukesh Rathor
2012-04-17 9:05 ` Ian Campbell
2012-04-18 23:29 ` Mukesh Rathor
2012-04-19 7:22 ` Ian Campbell
2012-04-19 14:15 ` Tim Deegan
2012-04-24 1:37 ` Mukesh Rathor
2012-04-24 9:36 ` Tim Deegan
2012-04-24 23:06 ` Mukesh Rathor
2012-04-26 9:08 ` Tim Deegan
2012-04-26 18:18 ` Mukesh Rathor [this message]
2012-04-26 19:57 ` Tim Deegan
2012-04-27 1:56 ` Mukesh Rathor
2012-04-27 8:51 ` Tim Deegan
[not found] <mailman.2710.1334825330.1399.xen-devel@lists.xen.org>
2012-04-19 14:40 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426111848.34e43e75@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=keir.xen@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.