From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [hybrid]: code review for function mapping pfn to
	foreign mfn
Date: Thu, 26 Apr 2012 20:57:12 +0100
Message-ID: <20120426195712.GG67043@ocelot.phlegethon.org>
References: <20120413182952.504e2775@mantra.us.oracle.com>
	<20120419141527.GB23663@ocelot.phlegethon.org>
	<20120423183709.5636656f@mantra.us.oracle.com>
	<20120424093626.GC34721@ocelot.phlegethon.org>
	<20120424160643.531daf88@mantra.us.oracle.com>
	<20120426090847.GA67043@ocelot.phlegethon.org>
	<20120426111848.34e43e75@mantra.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20120426111848.34e43e75@mantra.us.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Keir Fraser <keir.xen@gmail.com>, "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, "stefano.stabellini@eu.citrix.com" <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

At 11:18 -0700 on 26 Apr (1335439128), Mukesh Rathor wrote:
> On Thu, 26 Apr 2012 10:08:47 +0100
> Tim Deegan <tim@xen.org> wrote:
> 
> > At 16:06 -0700 on 24 Apr (1335283603), Mukesh Rathor wrote:
> > > On Tue, 24 Apr 2012 10:36:26 +0100
> > > Tim Deegan <tim@xen.org> wrote:
> > > 
> > > > At 18:37 -0700 on 23 Apr (1335206229), Mukesh Rathor wrote:
> > > > > On Thu, 19 Apr 2012 15:15:27 +0100
> > > > > Tim Deegan <tim@xen.org> wrote:
> > > 
> > > >you still have this mapping.  You should take a PGT_writeable_page
> > > >typecount, too, if the foreign domain isn't in paging_mode_external
> > > 
> > > Ok, I've it as:
> > >     if (paging_mode_external(fdom)) {
> > >         if (get_page_from_pagenr(mfn, fdom) == 0)
> > > 	    failed = 1;
> > >     } else {
> > >         if (get_page_and_type_from_pagenr(mfn, PGT_writable_page,
> > > fdom,0,0)) failed = 1;
> > >     }
> > > 
> > > But then later fails when it tries to pin the page,
> > > MMUEXT_PIN_L4_TABLE, from the lib at:
> > 
> > What's trying to pin an l4 table?  I thought your hybrid dom0 didn't
> > use the PV MMU.
> > 
> > Tim.
> 
> Right, hybrid doesn't use PV mmu. 
> Here, xl/xc is building a pv guest while running on *hybrid* dom0. 

Oh, I see.  This is the domU's L4.  In that case I suspect that what's
missing is the translation from GFNs to MFNs in the domU. 

To do that, we may finally have to reintroduce the dreaded 'tell me what
MFN backs this domU GFN' call, so the dom0 tools can build proper
pagetables and p2m for the pv domU.  Or have you already taken care of
that?

Tim.