All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] asm-generic: io: remove {read,write} string functions
Date: Fri, 27 Apr 2012 12:17:47 -0400	[thread overview]
Message-ID: <201204271217.50048.vapier@gentoo.org> (raw)
In-Reply-To: <1335523376-14695-1-git-send-email-will.deacon@arm.com>

[-- Attachment #1: Type: Text/Plain, Size: 933 bytes --]

On Friday 27 April 2012 06:42:55 Will Deacon wrote:
> The {read,write}s{b,w,l} functions are not defined across all
> architectures and therefore shouldn't be used by portable drivers. We
> should encourage driver writers to use the io{read,write}{8,16,32}_rep
> functions instead.

well, that isn't true today as a grep of the drivers/ tree shows.  perhaps we 
should fix that first ?  quite a number of architectures do implement these.

> This patch removes the {read,write} string functions for the generic IO
> header as they have no place in a new architecture port.

i don't see any file anywhere that describes what the baseline API is supposed 
to be, and what each set of funcs are for.  there is just the random ugliness 
in each arch's asm/io.h cobbled together until things work.  i think that also 
needs to be addressed before we go extending/contracting the API provides by 
asm-generic/io.h.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-04-27 16:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27 10:42 [PATCH 1/2] asm-generic: io: remove {read,write} string functions Will Deacon
2012-04-27 10:42 ` [PATCH 2/2] asm-generic: io: don't perform swab during {in,out} " Will Deacon
2012-04-27 12:12   ` Arnd Bergmann
2012-04-27 16:18   ` Mike Frysinger
2012-04-27 16:59     ` Will Deacon
2012-04-27 17:26       ` Mike Frysinger
2012-04-27 12:12 ` [PATCH 1/2] asm-generic: io: remove {read,write} " Arnd Bergmann
2012-04-27 16:17 ` Mike Frysinger [this message]
2012-04-27 16:53   ` Will Deacon
2012-04-27 17:18     ` Mike Frysinger
2012-04-28  8:46     ` Geert Uytterhoeven
2012-04-27 20:29   ` H. Peter Anvin
2012-04-27 16:23 ` H. Peter Anvin
2012-04-27 17:14   ` Will Deacon
2012-04-27 17:53     ` H. Peter Anvin
2012-04-27 20:52       ` Arnd Bergmann
2012-04-27 23:26         ` Mike Frysinger
2012-05-01 13:34           ` Will Deacon
2012-05-01 14:40             ` Arnd Bergmann
2012-05-01 18:28             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204271217.50048.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.